From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6D8FC77B7A for ; Mon, 29 May 2023 04:31:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 305FB84735; Mon, 29 May 2023 06:31:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Ph41IvV3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 619D5847C1; Mon, 29 May 2023 06:31:53 +0200 (CEST) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 84F5F84678 for ; Mon, 29 May 2023 06:31:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-51492ae66a4so2098184a12.1 for ; Sun, 28 May 2023 21:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685334710; x=1687926710; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qUhRvAC7ixKO/LEsVGyANmChCDUnahdk+ZYa9tM9AKg=; b=Ph41IvV3Ydhj+9YDe2aD5SkVZzGHYOR85z8WvKwkAgAKLPEBjL6SePCimiI5wd82O1 e/KIfhdXFQYt6574pO+I/0f+Ts62qey1kpRWrPqbMEYnKMRS6Fbd3bWCxQ1QoYUIpDI+ eKhxXkviIlbK8jtXeQVn/WifP5kgFmH3f66sARHw+E/V0vcJdsycJ4JDhSvxiTB679o2 dN8G8LXcodV/v9htW8Hb7JCrVeqNElK14+JgU38Fj9BIaDlHKFEQgAbGgWxWnO1ldhD8 IE/WP79NcJmPGGBk8YExQ2t58cMvy3dp5nIiJsPoklABj8Sf9NlxbfjsUBwpgd2Jmdh/ ZHXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685334710; x=1687926710; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qUhRvAC7ixKO/LEsVGyANmChCDUnahdk+ZYa9tM9AKg=; b=aizCwpcFNkAkaPGepAm6Pvsr5LajleMqEI48mFOcGOG7pXWLFlz13s0PvVvG8AQrbp h7NXBhImwCvsZ8yvzVsn5GJgImjdie3+W3IU56mCZLHHusUXoh1ZShzSIr9KKcqNXiR8 uj5zV/3kxtG97G2j2Q7kdmSx2/cWMWfSJAecy+r4F5XZ5577hQNNR9P6p/f8GrSV7+E9 EWPknqaecOaU2cfAnpSTHIYdcSL99zgXM7Udv6z0csI/VzuLRMyKpknehtshXtqwWy2r kvGV1I8ZhZOZXMqUR36BhHi3mF7fIDmGSjR0gLCLwig9TiH37qe8YJKs77wdCh2SUovm pocg== X-Gm-Message-State: AC+VfDyIhY0OUHfj+pgvIQ5Xz+qlu64X+ZSgs286TZ3ap2hMGNPDl43z 3IEE1rZSKCxzR37JeO6kY+WwmTQ01GhhACeRATQ= X-Google-Smtp-Source: ACHHUZ7hWm536rL5WsDM+l7CipWCMWzec8jAZgsea5/mAAfKn+SJzLOVd7RGAtuynqfyZ1GoblVFYetE3SzKGzPYevU= X-Received: by 2002:a17:906:ef0b:b0:973:91a5:bff1 with SMTP id f11-20020a170906ef0b00b0097391a5bff1mr9565574ejs.68.1685334709674; Sun, 28 May 2023 21:31:49 -0700 (PDT) MIME-Version: 1.0 References: <20230526124107.894-1-dlan@gentoo.org> <20230526124107.894-2-dlan@gentoo.org> In-Reply-To: From: Bin Meng Date: Mon, 29 May 2023 12:31:38 +0800 Message-ID: Subject: Re: [RESEND PATCH v1 1/4] riscv: t-head: licheepi4a: initial support added To: Yixun Lan Cc: Guo Ren , u-boot@lists.denx.de, Rick Chen , Leo , Wei Fu , Jisheng Zhang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, May 29, 2023 at 11:10=E2=80=AFAM Yixun Lan wrote: > > Hi Bin: > > On 09:12 Mon 29 May , Bin Meng wrote: > > On Sat, May 27, 2023 at 9:41=E2=80=AFPM Yixun Lan wro= te: > > > > > > Hi Guo, Jisheng: > > > > > > On 11:36 Sat 27 May , Guo Ren wrote: > > > > On Fri, May 26, 2023 at 8:41=E2=80=AFPM Yixun Lan = wrote: > > > > > > > > > > Add support for Sipeed's Lichee Pi 4A board which based on > > > > > T-HEAD's TH1520 SoC, only minimal device tree and serial onsole a= re enabled, > > > > > so it's capable of chain booting from T-HEAD's vendor u-boot. > > > > > > > > > > Reviewed-by: Wei Fu > > > > > Signed-off-by: Yixun Lan > > > > > --- > > > > > arch/riscv/Kconfig | 5 ++++ > > > > > board/thead/th1520_lpi4a/Kconfig | 42 ++++++++++++++++++++++= ++++++ > > > > > board/thead/th1520_lpi4a/MAINTAINERS | 7 +++++ > > > > > board/thead/th1520_lpi4a/Makefile | 5 ++++ > > > > > board/thead/th1520_lpi4a/board.c | 14 ++++++++++ > > > > > include/configs/th1520_lpi4a.h | 22 +++++++++++++++ > > > > > 6 files changed, 95 insertions(+) > > > > > create mode 100644 board/thead/th1520_lpi4a/Kconfig > > > > > create mode 100644 board/thead/th1520_lpi4a/MAINTAINERS > > > > > create mode 100644 board/thead/th1520_lpi4a/Makefile > > > > > create mode 100644 board/thead/th1520_lpi4a/board.c > > > > > create mode 100644 include/configs/th1520_lpi4a.h > > > > > > > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > > > > index f6ed05906a..419b6171a9 100644 > > > > > --- a/arch/riscv/Kconfig > > > > > +++ b/arch/riscv/Kconfig > > > > > @@ -27,6 +27,10 @@ config TARGET_SIFIVE_UNMATCHED > > > > > config TARGET_STARFIVE_VISIONFIVE2 > > > > > bool "Support StarFive VisionFive2 Board" > > > > > > > > > > +config TARGET_TH1520_LPI4A > > > > > + bool "Support Sipeed's TH1520 Lichee PI 4A Board" > > > > > + select SYS_CACHE_SHIFT_6 > > > > > + > > > > > config TARGET_SIPEED_MAIX > > > > > bool "Support Sipeed Maix Board" > > > > > select SYS_CACHE_SHIFT_6 > > > > > @@ -66,6 +70,7 @@ source "board/emulation/qemu-riscv/Kconfig" > > > > > source "board/microchip/mpfs_icicle/Kconfig" > > > > > source "board/sifive/unleashed/Kconfig" > > > > > source "board/sifive/unmatched/Kconfig" > > > > > +source "board/thead/th1520_lpi4a/Kconfig" > > > > > source "board/openpiton/riscv64/Kconfig" > > > > > source "board/sipeed/maix/Kconfig" > > > > > source "board/starfive/visionfive2/Kconfig" > > > > > diff --git a/board/thead/th1520_lpi4a/Kconfig b/board/thead/th152= 0_lpi4a/Kconfig > > > > > new file mode 100644 > > > > > index 0000000000..622246127c > > > > > --- /dev/null > > > > > +++ b/board/thead/th1520_lpi4a/Kconfig > > > > > @@ -0,0 +1,42 @@ > > > > > +if TARGET_TH1520_LPI4A > > > > > + > > > > > +config ARCH_THEAD > > > > > + bool > > > > > + default y > > > > > + > > > > > +config SYS_BOARD > > > > > + default "th1520_lpi4a" > > > for the board, I'm not sure whether people will prefer to keep the 't= h1520_' prefix, > > > otherwise we could make it shorter, leave only 'lpi4a'? thoughts? > > > > > > > > + > > > > > +config SYS_VENDOR > > > > > + default "thread" > > > ~~~~~~~ notice, in my original patch, it's 'thead= ' > > > > default "T-HEAD" > > > No, here should be 'thead', since the CONFIG_SYS_VENDOR will form > > > board/${CONFIG_SYS_VENDOR}, please consult arch/Kconfig for reference= . > > > > > > I personally would prefer 't-head' which probably cause less confusio= n.. > > > but since kernel use 'thead'[1], so I just follow it to keep them ali= gned. > > > > > > > But you have a typo here :) > do you mean 'thread'? It's 'thead' actually in my original patch, so no t= ypo.. > I was already trying to clarify this. > > It's probably a grammar correction when Guo reply the email > > https://lore.kernel.org/all/20230526124107.894-2-dlan@gentoo.org/ > > > > > [1] in kernel, the dts path consist of 'thead', e.g. arch/riscv/boot/= dts/thead/ I see. Thanks for the clarification! Regards, Bin