From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Sat, 1 May 2021 09:22:56 +0800
Subject: [PATCH v2 2/2] of: addr: Remove call to dev_count_cells() in
 of_get_address()
In-Reply-To: <CAPnjgZ0Q9PQwb_6xykGNZBb+_e7KTFJHt2RP38u8ZV91SErdyA@mail.gmail.com>
References: <20210430131659.19119-1-bmeng.cn@gmail.com>
 <20210430131659.19119-2-bmeng.cn@gmail.com>
 <CAPnjgZ0Q9PQwb_6xykGNZBb+_e7KTFJHt2RP38u8ZV91SErdyA@mail.gmail.com>
Message-ID: <CAEUhbmV1C6i4C-_E668a+nr6UwT41=obur8mqFqPnzJuWnWBxQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On Sat, May 1, 2021 at 2:14 AM Simon Glass <sjg@chromium.org> wrote:
>
> On Fri, 30 Apr 2021 at 07:17, Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > In of_get_address(), there is:
> >
> >   dev_count_cells(dev, &na, &ns);
> >
> > followed by:
> >
> >   bus->count_cells(dev, &na, &ns);
> >
> > but no codes in between use na/ns, hence the first call is useless.
> > By dropping the first call, dev_count_cells() is now useless too.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > ---
> >
> > Changes in v2:
> > - new patch: of: addr: Remove call to dev_count_cells() in of_get_address()
> >
> >  drivers/core/of_addr.c | 6 ------
> >  1 file changed, 6 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> I wonder why this is now different from linux?

With this patch, the code flow is the same as Linux.

Regards,
Bin