From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Thu, 25 Oct 2018 10:50:30 +0800
Subject: [U-Boot] [PATCH 09/30] riscv: move target selection into
	separate file
In-Reply-To: <CAN5B=eKoQOknzM4yeG4dMiA1QJgia8UCPeu9taLJevPeu7vvUw@mail.gmail.com>
References: <20181019220743.15020-1-lukas.auer@aisec.fraunhofer.de>
 <20181019220743.15020-10-lukas.auer@aisec.fraunhofer.de>
 <CAEUhbmUeVO4rTYhY=W35B4kAKxcMf5XZV46m6WPV4G1zdAgthg@mail.gmail.com>
 <752D002CFF5D0F4FA35C0100F1D73F3FA3A37D41@ATCPCS16.andestech.com>
 <CAN5B=eKoQOknzM4yeG4dMiA1QJgia8UCPeu9taLJevPeu7vvUw@mail.gmail.com>
Message-ID: <CAEUhbmV1e33yqY83w+CBtwmEMfir_msk3MXnyJv_OvhwNj+BMg@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, Oct 23, 2018 at 10:48 AM Rick Chen <rickchen36@gmail.com> wrote:
>
> > > Subject: Re: [PATCH 09/30] riscv: move target selection into separate file
> > >
> > > Hi Lukas,
> > >
> > > On Sat, Oct 20, 2018 at 6:10 AM Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > wrote:
> > > >
> > > > Move the target selection into a separate file (Kconfig.board) to
> > > > avoid clutter once we support more boards.
> > > >
> > > > Signed-off-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > > ---
> > > >
> > > >  arch/riscv/Kconfig       | 17 ++---------------
> > > >  arch/riscv/Kconfig.board | 14 ++++++++++++++
> > > >  2 files changed, 16 insertions(+), 15 deletions(-)  create mode
> > > > 100644 arch/riscv/Kconfig.board
> > > >
> > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index
> > > > ce07fb4b55..10d17a0e18 100644
> > > > --- a/arch/riscv/Kconfig
> > > > +++ b/arch/riscv/Kconfig
> > > > @@ -4,21 +4,6 @@ menu "RISC-V architecture"
> > > >  config SYS_ARCH
> > > >         default "riscv"
> > > >
> > > > -choice
> > > > -       prompt "Target select"
> > > > -       optional
> > > > -
> > > > -config TARGET_AX25_AE350
> > > > -       bool "Support ax25-ae350"
> > > > -
> > > > -config TARGET_QEMU_VIRT
> > > > -       bool "Support QEMU Virt Board"
> > > > -
> > > > -endchoice
> > > > -
> > > > -source "board/AndesTech/ax25-ae350/Kconfig"
> > > > -source "board/emulation/qemu-riscv/Kconfig"
> > > > -
> > > >  choice
> > > >         prompt "Base ISA"
> > > >         default ARCH_RV32I
> > > > @@ -72,4 +57,6 @@ config 32BIT
> > > >  config 64BIT
> > > >         bool
> > > >
> > > > +source "arch/riscv/Kconfig.board"
> > > > +
> > >
> > > I am OK with moving board one to a separate file, though it looks no other arch
> > > uses scuh convention in U-Boot :)
> > >
>
> Though no other arch use Kconfig.board here.
> Because RISC-V is an open architechture.
> Maybe separate board option from Kconfig to Kconfig.board is an good idea.
>

I suggest we keep current kconfig structure for now to be in
consistent with other archs.

Regards,
Bin