From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA84C433DB for ; Wed, 10 Mar 2021 08:54:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0BC864FE2 for ; Wed, 10 Mar 2021 08:54:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0BC864FE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJubz-0005w2-HA for qemu-devel@archiver.kernel.org; Wed, 10 Mar 2021 03:54:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJuWT-00088b-It; Wed, 10 Mar 2021 03:48:53 -0500 Received: from mail-yb1-xb2b.google.com ([2607:f8b0:4864:20::b2b]:43278) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJuWL-0007wT-RY; Wed, 10 Mar 2021 03:48:53 -0500 Received: by mail-yb1-xb2b.google.com with SMTP id u75so16996878ybi.10; Wed, 10 Mar 2021 00:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=x8u0ZUHuFb0LNEZQcY6afcc0NXL5vnd8e4OAqoaNRsI=; b=ux51/yowJ0wCR5DfjIqCvhL/USc6mnCTJjQ1cjZk8CmPJaL0mOeQIqft57R4e+10v+ AWqThJveitOpuD1xJ9eTzZWyA3gGFAtqKwHyObKKQQrZHeUbxUFr6f+jOsRE89vNIhG5 D00Ya/L0Q4CvpDe39cE635cXWZQjCcTWrZVe4rfuIOMcqZPaXL1xzvJs3ckDpoHlAx8Y BpXtNkubE87KqnlN7avV0BTO0cYtePUHn+Ez+MLY2RpZ/W2dFatrg6nVhgeiZ/9ihgZA RxTeYJG3IZ1nPiJWPuBeRx3vIlVjODHo9a3k39p7wWjWQU5oozE/kr83JQlk4bjHJJ0F 0P7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=x8u0ZUHuFb0LNEZQcY6afcc0NXL5vnd8e4OAqoaNRsI=; b=T+ndFuWZmP0TLqLowZjUQhd8OIW7KiH/iuiF0X+8PnVtitjyJgBgiJkIFpbjd2ixM9 bN0vmbj0wu/SQedumFfrX3c/E9B30oZJebs6qFX8kpReTwT8KV3P7Xw2x04lk1QUBOgG hkeq06kJPCQtvt2Whq1mCuj9l+u1L3NsutKpxBDppIa+FxDL7kuBeVgVwX1QNzHBPFxu OUaG8ncy1VXJlq2QolGz/h3su5S1mO4jpTx5Mwzukdsh883yhWKWNmK3LALrp0/mZFI+ v66wYMR3L3hEj4p59m8ylg/KhN7T7xhg9VGm4U47rZqdxl7ZzaPxwCzlXIk0hJJUoJmS p3yA== X-Gm-Message-State: AOAM5313aUVLdafXab7o7SlzHy9te+URNoeLwPejw5bZTnveb9+OeSRx kOJpHrTlLRPU7FCjmD7wEYBClnW+v0GaBg0gaeyCQvku X-Google-Smtp-Source: ABdhPJzxdA//kTOvlvjDHNdLMe8Z207zBld1Y7lPcTt9UFCFM4a8cGvKbpRaQ7dWwmIx1weUcsFN31pXGqocA1AYKIM= X-Received: by 2002:a5b:147:: with SMTP id c7mr2765852ybp.332.1615366123864; Wed, 10 Mar 2021 00:48:43 -0800 (PST) MIME-Version: 1.0 References: <20210309235028.912078-1-philmd@redhat.com> <20210309235028.912078-3-philmd@redhat.com> In-Reply-To: <20210309235028.912078-3-philmd@redhat.com> From: Bin Meng Date: Wed, 10 Mar 2021 16:48:31 +0800 Message-ID: Subject: Re: [PATCH 2/9] hw/block/pflash_cfi01: Extract pflash_cfi01_fill_cfi_table() To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::b2b; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stephen Checkoway , Qemu-block , "qemu-devel@nongnu.org Developers" , Max Reitz , David Edmondson , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Mar 10, 2021 at 7:51 AM Philippe Mathieu-Daud=C3=A9 wrote: > > Fill the CFI table in out of DeviceRealize() in a new function: > pflash_cfi01_fill_cfi_table(). > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/block/pflash_cfi01.c | 140 +++++++++++++++++++++------------------- > 1 file changed, 73 insertions(+), 67 deletions(-) > Reviewed-by: Bin Meng