From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] dm: sysreset: x86: missing build dependency
Date: Sun, 29 Jul 2018 08:34:34 +0800 [thread overview]
Message-ID: <CAEUhbmV6GEG1XUEnE4Rk5Q=HFjQ5Ug6mc8eyu0R8sNv3er=seg@mail.gmail.com> (raw)
In-Reply-To: <e8f5a7e2-1af4-c25d-c888-8828c83c3e69@gmx.de>
Hi Heinrich,
On Sun, Jul 29, 2018 at 5:44 AM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> On 07/23/2018 03:51 AM, Bin Meng wrote:
>> Hi Heinrich,
>>
>> On Sun, Jul 22, 2018 at 5:48 PM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>>> make qemu-x86_defconfig
>>> with additional
>>>
>>> #CONFIG_SYSRESET is not set
>>>
>>
>> I don't understand the changes. Why do you want to add
>> "#CONFIG_SYSRESET is not set"?
>
> I was astonished that a configuration file I was using suddenly was
> failing after your patch was merged. I analyzed the problem and found
> the missing dependency.
>
> In general it should not be possible to create a configuration that
> cannot be built. One tool to verify this is the U-Boot randconfig target.
>
Yes, that's the goal, however I doubt currently we achieved such goal.
Using "Fixes: fabb2b4c7f28 ("dm: sysreset: x86: Add a sysreset
driver")" misleads people, as you are not using the default
configuration. If we want to support such random build for sysreset, I
think we should put the below driver under "if SYSRESET" too, not just
x86.
41 config SYSRESET_SYSCON
42 bool "Enable support for mfd syscon reboot driver"
43 select REGMAP
44 select SYSCON
45 help
46 Reboot support for generic SYSCON mapped register reset.
47
48 config SYSRESET_WATCHDOG
49 bool "Enable support for watchdog reboot driver"
50 select WDT
51 help
52 Reboot support for generic watchdog reset.
53
Regards,
Bin
prev parent reply other threads:[~2018-07-29 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-22 9:48 [U-Boot] [PATCH 1/1] dm: sysreset: x86: missing build dependency Heinrich Schuchardt
2018-07-23 1:51 ` Bin Meng
2018-07-28 21:44 ` Heinrich Schuchardt
2018-07-29 0:34 ` Bin Meng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEUhbmV6GEG1XUEnE4Rk5Q=HFjQ5Ug6mc8eyu0R8sNv3er=seg@mail.gmail.com' \
--to=bmeng.cn@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.