From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B779BC433EF for ; Sun, 26 Sep 2021 08:40:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 593FD60F11 for ; Sun, 26 Sep 2021 08:40:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 593FD60F11 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUPhn-0002Vh-CB for qemu-devel@archiver.kernel.org; Sun, 26 Sep 2021 04:40:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUPft-0001Gj-4Z; Sun, 26 Sep 2021 04:38:17 -0400 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]:44955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUPfp-0004Zt-Sb; Sun, 26 Sep 2021 04:38:16 -0400 Received: by mail-yb1-xb2a.google.com with SMTP id f133so16331568yba.11; Sun, 26 Sep 2021 01:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=X6vH14M3cNEwL74vqYJumh/hQ0a2dklGUYwGnYcoqJ8=; b=O1HDoNRQStM/xne30syd8fi5dz0nJIo3H2x6d+vjmVAWIsQRVmlbNI7hiza1t1GQs8 abA+BlCK3ijMIyG9CL+0qukWGzHofOcBBB6BFy9qz1AUMqf5sGMq8/vNB4sQDnzmJjZW QIe1zx6+75AxSMjPHmhXWDZWLby2S7khjcWbVKcfojks1Dilp36fejJz4JJlWW6OX8jM hyszq3mi7p2ryRmSuJyA5zlPGmuFsDNLF9oMIyblXTjiA4Y9+/wr1YeSRByf8voiVwOH cWY7x3rQ+F7NSvpKe1YfsGI5D2R/TzyE4bYMXAQUODb3aUQWP+ePi9JxsNYe6HHWFVFg xQrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=X6vH14M3cNEwL74vqYJumh/hQ0a2dklGUYwGnYcoqJ8=; b=4UiUaZWNhVywvM/d34JPcRoecejQ0Vk/mACiavpzez3bY5XOWvq4HOB098B13xqayy zgOXMceqfuUkOFBXig4ZvN6OIOEM4WZqhVHN/wWBp79+qNLRB6xtlFyHTSgxEnIr44xO QjDS89TSDYTgQeYaKU6acdTHPK/WcP5r9E6lZuPbfKtljY+MBfHmryU69UR/1reNZPEb FH5gCzVpaXIedU/44G4SVr/soOKEw098KcZezaA7lyZWu8vO+i9hvgLkMJiltifRRpVQ XD68GeEv3tyHQxuoXh8rCE8VhZHcZxMRqExXS4bWboVRUqa0uKIseDn27LeiVhhq85JD FANw== X-Gm-Message-State: AOAM53150Obdg4G18KCgdmJKFzLasc2NcWn28KNDzf3jj5lpZn9gT0Fj Qk6t2sin8ivhiAfDJw3X2YXO9Y8SMtV5+J+cbW0= X-Google-Smtp-Source: ABdhPJzQvRgUW9qQiETfXqrvDQhPDFhyFzyVQuZFvy5O+oaVBCUzbqb7jwekuWUfr6oE5quvZq58SqIu+If3VrxNh7M= X-Received: by 2002:a25:5956:: with SMTP id n83mr21832868ybb.109.1632645492043; Sun, 26 Sep 2021 01:38:12 -0700 (PDT) MIME-Version: 1.0 References: <20210925133407.1259392-1-f4bug@amsat.org> <20210925133407.1259392-2-f4bug@amsat.org> In-Reply-To: From: Bin Meng Date: Sun, 26 Sep 2021 16:38:01 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] hw/char/mchp_pfsoc_mmuart: Simplify MCHP_PFSOC_MMUART_REG definition To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::b2a; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb2a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Bin Meng , "qemu-devel@nongnu.org Developers" , Paolo Bonzini , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, Sep 26, 2021 at 4:31 PM Bin Meng wrote: > > On Sat, Sep 25, 2021 at 9:34 PM Philippe Mathieu-Daud=C3=A9 wrote: > > > > The current MCHP_PFSOC_MMUART_REG_SIZE definition represent the > > size occupied by all the registers. However all registers are > > 32-bit wide, and the MemoryRegionOps handlers are restricted to > > 32-bit: > > > > static const MemoryRegionOps mchp_pfsoc_mmuart_ops =3D { > > .read =3D mchp_pfsoc_mmuart_read, > > .write =3D mchp_pfsoc_mmuart_write, > > .impl =3D { > > .min_access_size =3D 4, > > .max_access_size =3D 4, > > }, > > > > Avoid being triskaidekaphobic, simplify by using the number of > > typo? See https://www.dictionary.com/browse/triskaidekaphobia > > Learned a new word today but I have to say this word is too hard for a > non-native speaker :) > Never mind, triskaidekaphobia is a noun, and triskaidekaphobic is the adjective which is grammarly correct :) > > registers. > > > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > --- > > include/hw/char/mchp_pfsoc_mmuart.h | 4 ++-- > > hw/char/mchp_pfsoc_mmuart.c | 14 ++++++++------ > > 2 files changed, 10 insertions(+), 8 deletions(-) > > > > Reviewed-by: Bin Meng > Tested-by: Bin Meng Regards, Bin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mUPg0-0001JW-Hi for mharc-qemu-riscv@gnu.org; Sun, 26 Sep 2021 04:38:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUPft-0001Gj-4Z; Sun, 26 Sep 2021 04:38:17 -0400 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]:44955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUPfp-0004Zt-Sb; Sun, 26 Sep 2021 04:38:16 -0400 Received: by mail-yb1-xb2a.google.com with SMTP id f133so16331568yba.11; Sun, 26 Sep 2021 01:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=X6vH14M3cNEwL74vqYJumh/hQ0a2dklGUYwGnYcoqJ8=; b=O1HDoNRQStM/xne30syd8fi5dz0nJIo3H2x6d+vjmVAWIsQRVmlbNI7hiza1t1GQs8 abA+BlCK3ijMIyG9CL+0qukWGzHofOcBBB6BFy9qz1AUMqf5sGMq8/vNB4sQDnzmJjZW QIe1zx6+75AxSMjPHmhXWDZWLby2S7khjcWbVKcfojks1Dilp36fejJz4JJlWW6OX8jM hyszq3mi7p2ryRmSuJyA5zlPGmuFsDNLF9oMIyblXTjiA4Y9+/wr1YeSRByf8voiVwOH cWY7x3rQ+F7NSvpKe1YfsGI5D2R/TzyE4bYMXAQUODb3aUQWP+ePi9JxsNYe6HHWFVFg xQrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=X6vH14M3cNEwL74vqYJumh/hQ0a2dklGUYwGnYcoqJ8=; b=4UiUaZWNhVywvM/d34JPcRoecejQ0Vk/mACiavpzez3bY5XOWvq4HOB098B13xqayy zgOXMceqfuUkOFBXig4ZvN6OIOEM4WZqhVHN/wWBp79+qNLRB6xtlFyHTSgxEnIr44xO QjDS89TSDYTgQeYaKU6acdTHPK/WcP5r9E6lZuPbfKtljY+MBfHmryU69UR/1reNZPEb FH5gCzVpaXIedU/44G4SVr/soOKEw098KcZezaA7lyZWu8vO+i9hvgLkMJiltifRRpVQ XD68GeEv3tyHQxuoXh8rCE8VhZHcZxMRqExXS4bWboVRUqa0uKIseDn27LeiVhhq85JD FANw== X-Gm-Message-State: AOAM53150Obdg4G18KCgdmJKFzLasc2NcWn28KNDzf3jj5lpZn9gT0Fj Qk6t2sin8ivhiAfDJw3X2YXO9Y8SMtV5+J+cbW0= X-Google-Smtp-Source: ABdhPJzQvRgUW9qQiETfXqrvDQhPDFhyFzyVQuZFvy5O+oaVBCUzbqb7jwekuWUfr6oE5quvZq58SqIu+If3VrxNh7M= X-Received: by 2002:a25:5956:: with SMTP id n83mr21832868ybb.109.1632645492043; Sun, 26 Sep 2021 01:38:12 -0700 (PDT) MIME-Version: 1.0 References: <20210925133407.1259392-1-f4bug@amsat.org> <20210925133407.1259392-2-f4bug@amsat.org> In-Reply-To: From: Bin Meng Date: Sun, 26 Sep 2021 16:38:01 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] hw/char/mchp_pfsoc_mmuart: Simplify MCHP_PFSOC_MMUART_REG definition To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: "qemu-devel@nongnu.org Developers" , "open list:RISC-V" , Bin Meng , Alistair Francis , Paolo Bonzini , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::b2a; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb2a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Sep 2021 08:38:19 -0000 On Sun, Sep 26, 2021 at 4:31 PM Bin Meng wrote: > > On Sat, Sep 25, 2021 at 9:34 PM Philippe Mathieu-Daud=C3=A9 wrote: > > > > The current MCHP_PFSOC_MMUART_REG_SIZE definition represent the > > size occupied by all the registers. However all registers are > > 32-bit wide, and the MemoryRegionOps handlers are restricted to > > 32-bit: > > > > static const MemoryRegionOps mchp_pfsoc_mmuart_ops =3D { > > .read =3D mchp_pfsoc_mmuart_read, > > .write =3D mchp_pfsoc_mmuart_write, > > .impl =3D { > > .min_access_size =3D 4, > > .max_access_size =3D 4, > > }, > > > > Avoid being triskaidekaphobic, simplify by using the number of > > typo? See https://www.dictionary.com/browse/triskaidekaphobia > > Learned a new word today but I have to say this word is too hard for a > non-native speaker :) > Never mind, triskaidekaphobia is a noun, and triskaidekaphobic is the adjective which is grammarly correct :) > > registers. > > > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > --- > > include/hw/char/mchp_pfsoc_mmuart.h | 4 ++-- > > hw/char/mchp_pfsoc_mmuart.c | 14 ++++++++------ > > 2 files changed, 10 insertions(+), 8 deletions(-) > > > > Reviewed-by: Bin Meng > Tested-by: Bin Meng Regards, Bin