From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C94C433F5 for ; Mon, 1 Nov 2021 08:43:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B46E760551 for ; Mon, 1 Nov 2021 08:43:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B46E760551 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9CA628343E; Mon, 1 Nov 2021 09:43:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GulyajVJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C37CD83410; Mon, 1 Nov 2021 09:43:43 +0100 (CET) Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BB9EC8343E for ; Mon, 1 Nov 2021 09:43:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-yb1-xb33.google.com with SMTP id o12so42863159ybk.1 for ; Mon, 01 Nov 2021 01:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zd0xs7PwiNXYIWwlpNzLcMVO45WodWvmUBJGQX9S/go=; b=GulyajVJ30rOMktckUyXlYLXi580o3sg9pKYgK+5o9mxVqE9mDP0hFip76KR1LkYM+ fzPfllvyypJRVd6X6L8Urri3ZscWZV2+/FYHcUAp6K6w00ZTRsq+9meduewyNKPbCujh q1hNrwc9M6c0dYZNvmzoqmrhNCzPHEqwjMES3IohLnICJpHSL+RzKg3OtY5HPbEy5DWa XiN1EUrJnmqykcSRHqzS6TNfbikyuUOlRiUKL1oFZ6bqklQlKs9zEoZft+tuxKttJpOb lLrWuwmqd70xutrJt9LZf8QL4vbvKxTNkvyZrCsrbEuhEzQNsF64InNf3Deu0yBBEU/n Euzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zd0xs7PwiNXYIWwlpNzLcMVO45WodWvmUBJGQX9S/go=; b=HWAxU52A3M1JEb5mxP5xanVnvHvdYgBVhi+BrOonjVFY7OObU4AHnVZ1ASfMXmkTpI AVKs9HuMfVvYDm64q6Wy1o74KjzNtfO8ztl+s/O9wzTaM2xECm7hT/NuSomts6R/lLtT xFBP/zYKpCu1eow/vlWnJNdp6myHtWkxUaBRCLPkhzk6MSefTCJZjnc6dES3r7G3Fk/M 50TTz83w5mbpotdmPxr4n2W/zDExYL9dfbu4MwTdhBepBspFeLlKo96bZ+YhjlPJu5u3 AfRiVDVnkyHKqvGAyticdB9vA6payx28pbNhCDg/GppdJI8doiYrEbj84WOTuQMzq616 /KQg== X-Gm-Message-State: AOAM5329X28jGA5F/mg6uy2452h9Q/L6aVKT7GwJWNpQD9Ua/RwxTkWj vOuzzidqLsx4dhbsdvtrAH9/5S4OlyGXaoD1um9xlXf7 X-Google-Smtp-Source: ABdhPJw28N4tvQKqcjRWI3NH8ZZFNC2B88tEB0y0v/ODfsrE7r6yu867SgazoXOfla+y8HaT0INkTMP99f75K3g6fFc= X-Received: by 2002:a25:11ca:: with SMTP id 193mr28739845ybr.453.1635756216911; Mon, 01 Nov 2021 01:43:36 -0700 (PDT) MIME-Version: 1.0 References: <20211022085648.134655-1-padmarao.begari@microchip.com> <20211022085648.134655-3-padmarao.begari@microchip.com> In-Reply-To: <20211022085648.134655-3-padmarao.begari@microchip.com> From: Bin Meng Date: Mon, 1 Nov 2021 16:43:25 +0800 Message-ID: Subject: Re: [PATCH v1 2/5] riscv: Update Microchip MPFS Icicle Kit support To: Padmarao Begari Cc: U-Boot Mailing List , Rick Chen , Anup Patel , Atish Patra , Heiko Schocher , cyril.jean@microchip.com, Lewis Hanly , Conor Dooley , Daire McNamara , ivan.griffin@microchip.com, valentina.fernandezalanis@microchip.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Oct 22, 2021 at 4:58 PM Padmarao Begari wrote: > > This patch updates Microchip MPFS Icicle Kit support. For now, > add Microchip I2C driver, set environment variables for > mac addesses and default build for SBI_V02. > > Signed-off-by: Padmarao Begari > --- > board/microchip/mpfs_icicle/Kconfig | 5 +++++ > board/microchip/mpfs_icicle/mpfs_icicle.c | 17 ++++++++++++++++- > configs/microchip_mpfs_icicle_defconfig | 1 - > 3 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/board/microchip/mpfs_icicle/Kconfig b/board/microchip/mpfs_icicle/Kconfig > index 4678462378..092e411215 100644 > --- a/board/microchip/mpfs_icicle/Kconfig > +++ b/board/microchip/mpfs_icicle/Kconfig > @@ -45,5 +45,10 @@ config BOARD_SPECIFIC_OPTIONS # dummy > imply MMC_WRITE > imply MMC_SDHCI > imply MMC_SDHCI_CADENCE > + imply MMC_SDHCI_ADMA > + imply MMC_HS200_SUPPORT > + imply CMD_I2C > + imply DM_I2C > + imply SYS_I2C_MICROCHIP > > endif > diff --git a/board/microchip/mpfs_icicle/mpfs_icicle.c b/board/microchip/mpfs_icicle/mpfs_icicle.c > index afef719dff..e74c9fb03c 100644 > --- a/board/microchip/mpfs_icicle/mpfs_icicle.c > +++ b/board/microchip/mpfs_icicle/mpfs_icicle.c > @@ -119,7 +119,22 @@ int board_late_init(void) > if (icicle_mac_addr[idx] == ':') > icicle_mac_addr[idx] = ' '; > } > - env_set("icicle_mac_addr", icicle_mac_addr); > + env_set("icicle_mac_addr0", icicle_mac_addr); What's this environment for? Shouldn't the U-Boot standard environment variable "ethaddr" be set here? > + > + mac_addr[5] = device_serial_number[0] + 1; > + > + icicle_mac_addr[0] = '['; > + > + sprintf(&icicle_mac_addr[1], "%pM", mac_addr); "eth1addr"? > + > + icicle_mac_addr[18] = ']'; > + icicle_mac_addr[19] = '\0'; > + > + for (idx = 0; idx < 20; idx++) { > + if (icicle_mac_addr[idx] == ':') > + icicle_mac_addr[idx] = ' '; > + } > + env_set("icicle_mac_addr1", icicle_mac_addr); > > return 0; > } > diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig > index 90ae76cc12..b3c7e6db8f 100644 > --- a/configs/microchip_mpfs_icicle_defconfig > +++ b/configs/microchip_mpfs_icicle_defconfig > @@ -6,7 +6,6 @@ CONFIG_DEFAULT_DEVICE_TREE="microchip-mpfs-icicle-kit" > CONFIG_TARGET_MICROCHIP_ICICLE=y > CONFIG_ARCH_RV64I=y > CONFIG_RISCV_SMODE=y > -CONFIG_SBI_V01=y > CONFIG_DISTRO_DEFAULTS=y > CONFIG_SYS_LOAD_ADDR=0x80200000 > CONFIG_FIT=y > -- Regards, Bin