From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Sat, 2 Nov 2019 17:38:02 +0800 Subject: [U-Boot] [PATCH v3 001/108] binman: Correct symbol calculation with non-zero image base In-Reply-To: References: <20191021033322.217715-2-sjg@chromium.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Oct 28, 2019 at 11:27 AM Bin Meng wrote: > > On Mon, Oct 21, 2019 at 11:33 AM Simon Glass wrote: > > > > At present binman adds the image base address to the symbol value before > > it writes it to the binary. This is not correct since the symbol value > > itself (e.g. image position) has no relationship to the image base. > > > > Fix this and update the tests to cover this case. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v3: None > > Changes in v2: None > > > > tools/binman/elf.py | 4 +--- > > tools/binman/test/u_boot_binman_syms.lds | 2 +- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > > > Reviewed-by: Bin Meng applied to u-boot-x86, thanks!