From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70CD7C2B9F4 for ; Fri, 25 Jun 2021 07:29:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3695B60FD8 for ; Fri, 25 Jun 2021 07:29:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3695B60FD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwgHD-0002PO-7m for qemu-devel@archiver.kernel.org; Fri, 25 Jun 2021 03:29:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwgFJ-0000Z5-O3; Fri, 25 Jun 2021 03:27:25 -0400 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]:42897) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwgFI-00024E-3l; Fri, 25 Jun 2021 03:27:25 -0400 Received: by mail-yb1-xb2d.google.com with SMTP id 8so3245487ybn.9; Fri, 25 Jun 2021 00:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RpsjxhnHk1FNIcCdmLXszLkSUmiVW6+CpQQW2OZWlnM=; b=q2Qh9Q8foG5bRljkXGVxCW9/mbJLLxYBw3P1aM5qsKnaGQAPxRFXNJjXypjQFLOLiJ wQRS9b/4a/kHIDtuZY6gHyAwPevNz/Fkh7tzTG7pmt7Y9bRW7hz8gStJxp6EPYO1uoYR 9jpJFm6DjSDzjE3zhiib2UDnlNU4+583lDDDtAYZWUmWZeXTH4nacONWoEK6n0x5JrP4 bP8DACKyh2rMENfetkBIkjavbpknF3Rb/VspIor5F+FVnKWIciMiscItZ3QMYEBuwJ00 U2OCbEooJTDZ6DsTkMIp8OCR89oF9XKXTHZKlOU4dgczh14ztEaUWcEWOdGjsRd9Nyd7 fmyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RpsjxhnHk1FNIcCdmLXszLkSUmiVW6+CpQQW2OZWlnM=; b=TvAZCtmTar0ZMWoE8cYegts2PNy16uD0GVCvt/psugPdysI+16kIj/LtLe3Sh4Uf1A z6rLvEmn7/f0ZVT5lLmEAYk07OlaHpOw4qvKlkQ9ccQ7kSIgMU2TqZGfq0cTm8Fe32wP hRNAb/TquM4UTfDMY0eK5eV2SKXrz05Tj7R0hBVowA3uGFH1C6txYoa2bdaYhuV6CbsZ UKC+k1hFuqnLrpuyK1iyNSXWNIfEWTztuTi0SSORq+KeME03NSr/cWwMjlHFGcjoUV6J ExXtPWE4D1XXZ1FRuNoAXE/db8509sx0/eBnZImVxqnTuy7pj0C4Anv1Izw6F4/B8uYN 4Csg== X-Gm-Message-State: AOAM5305g2GHZYwHCRuUCC4+1FRYEzkzJEqML++3suTH033xbx9Tucxz 5yq5iObZhSTyyTpuEz+Zy7E3GJHtvLqg/2cv7go= X-Google-Smtp-Source: ABdhPJwJRsHbnai505ekpAuFFgL2ppLF4l+rRIO+KpJ7A8RgUxKzJcvoScOms+Cx5ahM8ahDE8300ff2DMZRkyojVlc= X-Received: by 2002:a25:4297:: with SMTP id p145mr8370573yba.387.1624606042164; Fri, 25 Jun 2021 00:27:22 -0700 (PDT) MIME-Version: 1.0 References: <20210624142209.1193073-1-f4bug@amsat.org> <20210624142209.1193073-2-f4bug@amsat.org> In-Reply-To: <20210624142209.1193073-2-f4bug@amsat.org> From: Bin Meng Date: Fri, 25 Jun 2021 15:27:10 +0800 Message-ID: Subject: Re: [RFC PATCH 01/10] hw/sd: When card is in wrong state, log which state it is To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::b2d; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qemu-block , Andrew Jeffery , Bin Meng , "qemu-devel@nongnu.org Developers" , Joel Stanley , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 24, 2021 at 10:22 PM Philippe Mathieu-Daud=C3=A9 wrote: > > We report the card is in an inconsistent state, but don't precise %s/don't/is not > in which state it is. Add this information, as it is useful when > debugging problems. > > Since we will reuse this code, extract as sd_invalid_state_for_cmd() > helper. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/sd/sd.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng