From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Thu, 6 Sep 2018 17:12:37 +0800
Subject: [U-Boot] [PATCH 1/1] x86: qemu-x86 requires CONFIG_SYS_HZ=2000
In-Reply-To: <8368d50f-d5bc-425b-646e-2903f6b2295a@gmx.de>
References: <20180906060641.21512-1-xypron.glpk@gmx.de>
 <CAEUhbmUbFfQsy0Qg49ehnzLA+OH75sqsFn9jKvwwLO80D3JHgg@mail.gmail.com>
 <CAEUhbmU4w+3GTHPF00mCWKtbvFodDXg9SAgZZc58RyemOf17OA@mail.gmail.com>
 <8368d50f-d5bc-425b-646e-2903f6b2295a@gmx.de>
Message-ID: <CAEUhbmVK9nPm1opUdqPDzABtdU=cYY1w27eGxEKb3su-OEVa=Q@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Heinrich,

On Thu, Sep 6, 2018 at 3:30 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
>
>
> On 09/06/2018 08:55 AM, Bin Meng wrote:
> > On Thu, Sep 6, 2018 at 2:49 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >>
> >> Hi Heinrich,
> >>
> >> On Thu, Sep 6, 2018 at 2:06 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >>>
> >>> The sleep command only provides correct timings for
> >>> CONFIG_SYS_HZ=2000 on qemu-x86_defconfig.
> >>>
> >>> This can be tested with
> >>>
> >>>     date && sleep 4 && date
> >>
> >> With current u-boot/master, with the same test command you provided, I got:
> >>
> >> => date && sleep 4 && date
> >> Date: 2018-09-06 (Thursday)    Time:  6:47:28
> >> Date: 2018-09-06 (Thursday)    Time:  6:47:32
> >> => date && sleep 4 && date
> >> Date: 2018-09-06 (Thursday)    Time:  6:47:41
> >> Date: 2018-09-06 (Thursday)    Time:  6:47:45
> >> => date && sleep 4 && date
> >> Date: 2018-09-06 (Thursday)    Time:  6:47:47
> >> Date: 2018-09-06 (Thursday)    Time:  6:47:51
> >>
> >> It seems there is no issue.
> >>
> >> QEMU was invoked like this: qemu-system-i386 -nographic -bios u-boot.rom
> >
> > with '-smp 4', the issue still cannot be reproduced.
> >
> > I am using QEMU 2.5.0, shipped by Ubuntu 16.04.
> >
> > Regards,
> > Bin
> >
> Hello Bin,
>
> thanks for testing.
>
> I reran my tests with the same Debian Buster release and QEMU 2.12.0 on
> two machines, one with Intel CPU one with AMD Ryzen and I get different
> results.
>
> So my suggestion would be that I reduce the patch to only change
> lib/Kconfig to make CONFIG_SYS_HZ editable and keep the 1000 Hz default
> value. That way corrections become possible in .config. And we keep the
> defconfig as it is.
>

Sound good to me.

Regards,
Bin