From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20648C433F5 for ; Wed, 27 Oct 2021 03:28:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6819061073 for ; Wed, 27 Oct 2021 03:28:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6819061073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 63F648355C; Wed, 27 Oct 2021 05:28:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="N0NFvBM3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F203683571; Wed, 27 Oct 2021 05:28:34 +0200 (CEST) Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E326983538 for ; Wed, 27 Oct 2021 05:28:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-yb1-xb2f.google.com with SMTP id o12so2905238ybk.1 for ; Tue, 26 Oct 2021 20:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qqmZ0PsK5fcAtVPiVGTKKG3dkcLzo+hILiIdyOOoCh8=; b=N0NFvBM3ayD3hl3ClNnYMwpYxuuaMxvSTobiZh/fb2eXLG7ST2IRBf2e5XKY/3W1if YLEfQwJ66IqFxvsBvNUEOWRV91op5cZvPAhNd9vWEzYOoUyZE3SZYe49jXzjx4lPwAWS siMC3n1xzHluWxbQkj7b7jYDdP58Df1cWyPzdQLdp0LpvDYWhQiyzC2bBlUDR80L9Df3 g8GJ7zWhtaOcAUzFrYkuC8rzcsVFs9th1vfQpJ3XRCvrgt6RGBnusvh+QdDCLH4Ji14X MVDR9K38AFft/s1N1gIwExLktrEfimZw9cNl0V+picYkl08816QG1/npiT8ZZYIItmdp G+BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qqmZ0PsK5fcAtVPiVGTKKG3dkcLzo+hILiIdyOOoCh8=; b=KLEEafRkH/DUhcueTTG3jn1QeuREgjDLG2f2PYn0KXEJA2W7qnfpgrTL5aSWa7eXhX JN31yFxLa84BwbJ49xqMQ2CsOyB7mKGfN70Ne1MFm658ARudKMTK0E4FSzBQosLgFwGV CukuFZlG7od4cN4y4qm+wi4vL+T6ZxZVdSt1SqIPNt7tdfwzsURR0VHRP93R1xPQ3+En 8dMwg92WNvS65gATMYlusBUgSXPoqBdBBu1hNIbbVe+uwIR3XDW+USaTEZQZ7Nz59m46 6eWC8alPs6sCd6fOTZlmfharTBTSIGfpBBHOKu+wOG9Hf47J1uPqfvP8JnmT9dgFrKDa Ga/A== X-Gm-Message-State: AOAM5330uldqzuzyOVgxqQa55cXRefvJ3Lg75DQU3y1n6dRqCXj1CAHv 1msKKvzk70kJcNGr5WmwxTfEL14/15mGlYw03u0= X-Google-Smtp-Source: ABdhPJy0OYTEmv/DdMXG2lV65C7jkc5gLSi5SKCLTpuKbJVgLec+GqXWZ5/gRoNfLwiaLBGq8Z+EZvUzqDigPfn6c/8= X-Received: by 2002:a25:11ca:: with SMTP id 193mr2775350ybr.453.1635305310821; Tue, 26 Oct 2021 20:28:30 -0700 (PDT) MIME-Version: 1.0 References: <20211020213134.7534-1-adelva@google.com> <20211020213134.7534-2-adelva@google.com> In-Reply-To: From: Bin Meng Date: Wed, 27 Oct 2021 11:28:20 +0800 Message-ID: Subject: Re: [PATCH] x86: Fix i8254 ifdef include guard To: Alistair Delva Cc: U-Boot Mailing List , Simon Glass Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Oct 27, 2021 at 11:08 AM Bin Meng wrote: > > On Thu, Oct 21, 2021 at 5:31 AM Alistair Delva wrote: > > > > When building U-Boot with clang, it notices that the i8254.h include > > guard does not work correctly due to a typo. Fix it. > > > > Signed-off-by: Alistair Delva > > Cc: Simon Glass > > Cc: Bin Meng > > --- > > arch/x86/include/asm/i8254.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/include/asm/i8254.h b/arch/x86/include/asm/i8254.h > > index d769daf85d..bb8930338b 100644 > > --- a/arch/x86/include/asm/i8254.h > > +++ b/arch/x86/include/asm/i8254.h > > @@ -7,7 +7,7 @@ > > /* i8254.h Intel 8254 PIT registers */ > > > > #ifndef _ASMI386_I8254_H_ > > -#define _ASMI386_I8954_H_ > > +#define _ASMI386_I8254_H_ > > There is another I8954 at the end of this file. I can fix it when applying. > > > > > #define PIT_T0 0x00 /* PIT channel 0 count/status */ > > #define PIT_T1 0x01 /* PIT channel 1 count/status */ > > Reviewed-by: Bin Meng applied to u-boot-x86, thanks!