From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94B46C433E0 for ; Wed, 10 Feb 2021 11:19:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FB8564E2A for ; Wed, 10 Feb 2021 11:19:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FB8564E2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9nWc-0002IX-0x for qemu-devel@archiver.kernel.org; Wed, 10 Feb 2021 06:19:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9nV8-0000n9-Ik; Wed, 10 Feb 2021 06:17:42 -0500 Received: from mail-yb1-xb35.google.com ([2607:f8b0:4864:20::b35]:39542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9nV7-0006C3-1s; Wed, 10 Feb 2021 06:17:42 -0500 Received: by mail-yb1-xb35.google.com with SMTP id k4so1613494ybp.6; Wed, 10 Feb 2021 03:17:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5jtPwVBo2chsjfP5ZJtqmC8Me4uPu4eCBX5F4YMR3zM=; b=ZCYOVZY6g0agc3kL5UZy3Z0ltAbIbgfKwGglcAasHriGyTpvKafnTAtYoL2dri1Zlq SxSI6yPgujKLDstX12PYZBklqgNm5R/tlDzyABBxqr+ujEwlADBvRouKhh7LsdvZVBYq rIS5Tq+m1MLETlc24EajBRsffFnRZw+n/mcRo5nk637WBStrzMnMZREwLpUVjfHgtbT+ LIxUYPmnTjvEAUEmh8q094HtMe/bcCeN3AhcKELVTRktKqplN9B48k2soFbwMukdPWnn qNv11HGmjezXQ/J8KaQkwjzl0mI+ra7pA1DUg+QFBn8I3S1xMjCX/0MHZm5MdVRTacJq kEtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5jtPwVBo2chsjfP5ZJtqmC8Me4uPu4eCBX5F4YMR3zM=; b=RUAEArr6ieRnpu+8PNNpbtbKA0hJjL2Y+Bp0AEw1mbE/3EEK1jS7LHW3DGLOtYIgdS BUOCFa0QgqTWoCZrsL+AdCnqJR6+nm6YATxjrU0eV2ex9ymVvVfCI/tXgoXyyrDKg1YD rtb3MyQRbWQiJgWpcztn903uh+U2eOgo3YAMDoC48xMKuJxkiDXOo2GBbjTmzkgMGWue uY7XR1SDSPMHH0rA082SRUH+L6gOzcV3oCcjNxF/8QuiVT7FuuSlgHQVjrh2DLoukOU0 viP5J8eKaNwZm7UejbeAQcTENfR40TNGa7Ah7bGnH7SUjEtKMPHOI5ss6aVi0QhHvyEP /T+Q== X-Gm-Message-State: AOAM531sv2E6nnUaOLfTo3hYAW5oo2RmpltNs3qoyzhzCHtpmhMj8/6c +iPMqiDdhL5c0qSwwVUq3RaAW44I7w+/yb4G6sE= X-Google-Smtp-Source: ABdhPJzQ+2PeyEKWx+H7Gt0z3wx5uh78gzD+M5unl7r3uueYYOJTs0b3YPjffGDOhxdhzo1D1RVr5+HeSG/Rg5Wovx0= X-Received: by 2002:a25:8712:: with SMTP id a18mr3498020ybl.306.1612955859750; Wed, 10 Feb 2021 03:17:39 -0800 (PST) MIME-Version: 1.0 References: <1612952597-62595-1-git-send-email-bmeng.cn@gmail.com> <299d3bdc-268c-eccc-66be-6605b23a2c92@redhat.com> In-Reply-To: From: Bin Meng Date: Wed, 10 Feb 2021 19:17:28 +0800 Message-ID: Subject: Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature() To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::b35; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Thomas Huth , "Daniel P . Berrange" , Qemu-block , Bin Meng , "qemu-devel@nongnu.org Developers" , Max Reitz , Klaus Jensen , Minwoo Im , Keith Busch , =?UTF-8?B?QWxleCBCZW5uw6ll?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Philippe, On Wed, Feb 10, 2021 at 7:15 PM Philippe Mathieu-Daud=C3=A9 wrote: > > On 2/10/21 12:12 PM, Philippe Mathieu-Daud=C3=A9 wrote: > > Hi Bin, > > > > On 2/10/21 11:23 AM, Bin Meng wrote: > >> From: Bin Meng > >> > >> Current QEMU HEAD nvme.c does not compile: > >> > >> hw/block/nvme.c:3242:9: error: =E2=80=98result=E2=80=99 may be used = uninitialized in this function [-Werror=3Dmaybe-uninitialized] > >> trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled= "); > >> ^ > >> hw/block/nvme.c:3150:14: note: =E2=80=98result=E2=80=99 was declared= here > >> uint32_t result; > >> ^ > > > > Why isn't this catched by our CI? What is your host OS? Fedora 33? > > Just noticed v1 and Peter's explanation: > https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg03528.html > > Can you amend "default GCC 5.4 on a Ubuntu 16.04 host" information > please? > Sure. Regards, Bin