* [PATCH] nvme: Remove the redundant aqa value setting
@ 2021-06-22 3:34 Wesley Sheng
2021-06-23 9:14 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Wesley Sheng @ 2021-06-22 3:34 UTC (permalink / raw)
To: u-boot; +Cc: wesleyshenggit, wesley.sheng
From: Wesley Sheng <wesleyshenggit@sina.com>
AQA (Admin Queue Attributes) register is a dword size with
lower word of ASQS, and higher word of ACQS.
The code set the variable aqa twice, but it is redundant.
Signed-off-by: Wesley Sheng <wesleyshenggit@sina.com>
---
drivers/nvme/nvme.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c
index fc64d93ab8..a062234163 100644
--- a/drivers/nvme/nvme.c
+++ b/drivers/nvme/nvme.c
@@ -379,7 +379,6 @@ static int nvme_configure_admin_queue(struct nvme_dev *dev)
aqa = nvmeq->q_depth - 1;
aqa |= aqa << 16;
- aqa |= aqa << 16;
dev->page_size = 1 << page_shift;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: Remove the redundant aqa value setting
2021-06-22 3:34 [PATCH] nvme: Remove the redundant aqa value setting Wesley Sheng
@ 2021-06-23 9:14 ` Bin Meng
2021-06-23 9:19 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2021-06-23 9:14 UTC (permalink / raw)
To: Wesley Sheng; +Cc: U-Boot Mailing List, wesleyshenggit
On Tue, Jun 22, 2021 at 11:35 AM Wesley Sheng <wesley.sheng@amd.com> wrote:
>
> From: Wesley Sheng <wesleyshenggit@sina.com>
>
> AQA (Admin Queue Attributes) register is a dword size with
> lower word of ASQS, and higher word of ACQS.
>
> The code set the variable aqa twice, but it is redundant.
>
> Signed-off-by: Wesley Sheng <wesleyshenggit@sina.com>
> ---
> drivers/nvme/nvme.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: Remove the redundant aqa value setting
2021-06-23 9:14 ` Bin Meng
@ 2021-06-23 9:19 ` Bin Meng
0 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2021-06-23 9:19 UTC (permalink / raw)
To: Wesley Sheng; +Cc: U-Boot Mailing List, wesleyshenggit
On Wed, Jun 23, 2021 at 5:14 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Tue, Jun 22, 2021 at 11:35 AM Wesley Sheng <wesley.sheng@amd.com> wrote:
> >
> > From: Wesley Sheng <wesleyshenggit@sina.com>
> >
> > AQA (Admin Queue Attributes) register is a dword size with
> > lower word of ASQS, and higher word of ACQS.
> >
> > The code set the variable aqa twice, but it is redundant.
> >
> > Signed-off-by: Wesley Sheng <wesleyshenggit@sina.com>
> > ---
> > drivers/nvme/nvme.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme: Remove the redundant aqa value setting
2021-06-16 3:22 Wesley Sheng
@ 2021-06-18 6:01 ` Bin Meng
0 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2021-06-18 6:01 UTC (permalink / raw)
To: Wesley Sheng; +Cc: U-Boot Mailing List, wesleyshenggit
On Wed, Jun 16, 2021 at 12:09 PM Wesley Sheng <wesley.sheng@amd.com> wrote:
>
> From: wesleywesley <wesleyshenggit@sina.com>
>
> AQA (Admin Queue Attributes) register is a dword size with
> lower word of ASQS, and higher word of ACQS.
>
> The code set the variable aqa twice, but it is redundant.
>
> Signed-off-by: wesleywesley <wesleyshenggit@sina.com>
> ---
> drivers/nvme/nvme.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] nvme: Remove the redundant aqa value setting
@ 2021-06-16 3:22 Wesley Sheng
2021-06-18 6:01 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Wesley Sheng @ 2021-06-16 3:22 UTC (permalink / raw)
To: u-boot; +Cc: wesleyshenggit, wesley.sheng
From: wesleywesley <wesleyshenggit@sina.com>
AQA (Admin Queue Attributes) register is a dword size with
lower word of ASQS, and higher word of ACQS.
The code set the variable aqa twice, but it is redundant.
Signed-off-by: wesleywesley <wesleyshenggit@sina.com>
---
drivers/nvme/nvme.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c
index fc64d93ab8..a062234163 100644
--- a/drivers/nvme/nvme.c
+++ b/drivers/nvme/nvme.c
@@ -379,7 +379,6 @@ static int nvme_configure_admin_queue(struct nvme_dev *dev)
aqa = nvmeq->q_depth - 1;
aqa |= aqa << 16;
- aqa |= aqa << 16;
dev->page_size = 1 << page_shift;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-23 9:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 3:34 [PATCH] nvme: Remove the redundant aqa value setting Wesley Sheng
2021-06-23 9:14 ` Bin Meng
2021-06-23 9:19 ` Bin Meng
-- strict thread matches above, loose matches on Subject: below --
2021-06-16 3:22 Wesley Sheng
2021-06-18 6:01 ` Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.