From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Fri, 13 Apr 2018 11:30:09 +0800
Subject: [U-Boot] [PATCH v2 10/18] bios: vesa: Guard setting vesa mode
	with CONFIG_FRAMEBUFFER_SET_VESA_MODE
In-Reply-To: <CAPnjgZ3UAp_u6YzMOUx2D3Jz2wbatZHABkJNYDure5roNSDJqA@mail.gmail.com>
References: <1523509343-18123-1-git-send-email-bmeng.cn@gmail.com>
 <1523509343-18123-11-git-send-email-bmeng.cn@gmail.com>
 <CAPnjgZ3UAp_u6YzMOUx2D3Jz2wbatZHABkJNYDure5roNSDJqA@mail.gmail.com>
Message-ID: <CAEUhbmVPhMv+vwoCaCbUqF5v8fuuZOEeLqXzSAq3BWnXaL+71Q@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On Fri, Apr 13, 2018 at 12:42 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi Bin,
>
> On 11 April 2018 at 23:02, Bin Meng <bmeng.cn@gmail.com> wrote:
>> If CONFIG_FRAMEBUFFER_SET_VESA_MODE is not set, don't switch
>> graphics card to VESA mode. This applies to both native mode
>> and emulator mode of running the VGA BIOS.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/lib/bios.c             | 4 ++++
>>  drivers/bios_emulator/atibios.c | 4 ++++
>>  2 files changed, 8 insertions(+)
>
> Could this use if() instead of #ifdef ?
>

Not all of the changes can, so I chose use #ifdef

> Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Bin