From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Tue, 30 Jun 2020 14:42:57 +0800 Subject: [PATCH v1 20/43] x86: pinctrl: Set up itss in the probe() method In-Reply-To: <20200614215726.v1.20.Iabbdf4b844a81d8ba0382c512fa2becc47d6ed94@changeid> References: <20200615035738.248710-1-sjg@chromium.org> <20200614215726.v1.20.Iabbdf4b844a81d8ba0382c512fa2becc47d6ed94@changeid> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On Mon, Jun 15, 2020 at 11:58 AM Simon Glass wrote: > > At present the itss is probed in the ofdata_to_platdata() method. This is > incorrect since itss is a child of p2sb which itself needs to probe the > pinctrl device. This means that p2sb is effectively not probed when the > itss is probed, so we get the wrong register address from p2sb. > I wonder how this ever worked? > Fix this by moving the itss probe to the correct place. > > Signed-off-by: Simon Glass > --- > > drivers/pinctrl/intel/pinctrl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Bin Meng Regards, Bin