From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Tue, 29 Oct 2019 15:11:15 +0800
Subject: [U-Boot] [PATCH v2 1/5] tools: buildman: Honor output directory
 when generating boards.cfg
In-Reply-To: <CAPnjgZ0P56zbrgK2WQK40gD_qJXJk65jjaGi1Nkbp5CXwsrWiA@mail.gmail.com>
References: <1572272704-31204-1-git-send-email-bmeng.cn@gmail.com>
 <1572272704-31204-2-git-send-email-bmeng.cn@gmail.com>
 <CAPnjgZ0P56zbrgK2WQK40gD_qJXJk65jjaGi1Nkbp5CXwsrWiA@mail.gmail.com>
Message-ID: <CAEUhbmVYrmdtOsupeTpfQ_bXPT+5t-d3pELrDNP=bpErugxwiA@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On Tue, Oct 29, 2019 at 11:32 AM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Bin,
>
> On Mon, 28 Oct 2019 at 08:25, Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > buildman always generates boards.cfg in the U-Boot source tree.
> > When '-o' is given, we should generate boards.cfg to the given
> > output directory.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> >
> > Changes in v2: None
> >
> >  tools/buildman/control.py | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Does this preserve existing behaviour when -o is not given? I suppose

When -o is not given, the options.output_dir is the destination
directory and it's "../" by default.

But I suspect we should change the default output_dir to somewhere
else, in a separate patch, because arbitrarily put something in the
parent directory is not a good practice.

> it doesn't matter so long as buildman uses the right file?

Yes, it doesn't matter.

Regards,
Bin