All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 03/13] dm: pci: Skip setting VGA bridge bits if parent device is the host bus
Date: Thu, 15 Apr 2021 06:30:27 +0800	[thread overview]
Message-ID: <CAEUhbmVcJygMFB9LSfsuCfBqZO+To6aCioNqpVd04be1e-fk-Q@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ2wcLbr-Kqk2PdLjStWeuw0Wy82mEs4aPP5f1VxaGfM8A@mail.gmail.com>

Hi,

On Thu, Apr 15, 2021 at 3:39 AM Simon Glass <sjg@chromium.org> wrote:
>
> On Tue, 13 Apr 2021 at 16:23, Masami Hiramatsu
> <masami.hiramatsu@linaro.org> wrote:
> >
> > Commit bbbcb5262839 ("dm: pci: Enable VGA address forwarding on bridges")
> > sets the VGA bridge bits by checking pplat->class, but if the parent
> > device is the pci host bus device, it can be skipped. Moreover, it
> > shouldn't access the pplat because the parent has different plat data.
> >
> > Without this fix, "pci enum" command cause a synchronous abort.
> >
> > pci_auto_config_devices: start
> > PCI Autoconfig: Bus Memory region: [78000000-7fffffff],
> >                 Physical Memory [78000000-7fffffffx]
> > PCI Autoconfig: Bus I/O region: [0-ffff],
> >                 Physical Memory [77f00000-77f0ffffx]
> > pci_auto_config_devices: device pci_6:0.0
> > PCI Autoconfig: BAR 0, Mem, size=0x1000000, address=0x78000000 bus_lower=0x79000000
> >
> > PCI Autoconfig: BAR 1, Mem, size=0x8000000, No room in resource, avail start=79000000 / size=8000000, need=8000000
> > PCI: Failed autoconfig bar 14
> >
> > PCI Autoconfig: BAR 2, I/O, size=0x4, address=0x1000 bus_lower=0x1004
> >
> > PCI Autoconfig: BAR 3, Mem, size=0x2000000, address=0x7a000000 bus_lower=0x7c000000
> >
> > PCI Autoconfig: BAR 4, I/O, size=0x80, address=0x1080 bus_lower=0x1100
> >
> > PCI Autoconfig: ROM, size=0x80000, address=0x7c000000 bus_lower=0x7c080000
> >
> > "Synchronous Abort" handler, esr 0x96000006
> > elr: 00000000e002bd28 lr : 00000000e002bce8 (reloc)
> > elr: 00000000fff6fd28 lr : 00000000fff6fce8
> > x0 : 0000000000001041 x1 : 000000000000003e
> > x2 : 00000000ffb0f8c8 x3 : 0000000000000001
> > x4 : 0000000000000080 x5 : 0000000000000000
> > x6 : 00000000fff718fc x7 : 000000000000000f
> > x8 : 00000000ffb0f238 x9 : 0000000000000008
> > x10: 0000000000000000 x11: 0000000000000010
> > x12: 0000000000000006 x13: 000000000001869f
> > x14: 00000000ffb0fcd0 x15: 0000000000000020
> > x16: 00000000fff71cc4 x17: 0000000000000000
> > x18: 00000000ffb13d90 x19: 00000000ffb14320
> > x20: 0000000000000000 x21: 00000000ffb14090
> > x22: 00000000ffb0f8c8 x23: 0000000000000001
> > x24: 00000000ffb14c10 x25: 0000000000000000
> > x26: 0000000000000000 x27: 0000000000000000
> > x28: 00000000ffb14c70 x29: 00000000ffb0f830
> >
> > Code: 52800843 52800061 52800e00 97ffcf65 (b9400280)
> > Resetting CPU ...
> >
> > Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> > ---
> >  drivers/pci/pci-uclass.c |    3 +++
> >  1 file changed, 3 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

I can't find this patch in my inbox, nor in the patchwork.

Could you please resend?

Regards,
Bin

  reply	other threads:[~2021-04-14 22:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <161832714362.562320.8024090839631691588.stgit@localhost>
     [not found] ` <161832781487.562320.49203469390042692.stgit@localhost>
2021-04-13 17:47   ` [PATCH 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox Tom Rini
2021-04-14  1:06     ` Masami Hiramatsu
2021-04-14 17:32       ` Tom Rini
2021-04-16  9:13         ` Masami Hiramatsu
     [not found] ` <161832788118.562320.11063528179837203251.stgit@localhost>
2021-04-13 17:47   ` [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support Tom Rini
2021-04-14  1:12     ` Masami Hiramatsu
2021-04-14  1:27       ` Takahiro Akashi
2021-04-14  2:06         ` Masami Hiramatsu
2021-04-14  4:48           ` Takahiro Akashi
2021-04-14  6:29             ` Masami Hiramatsu
2021-04-14  7:13               ` Takahiro Akashi
2021-04-14 17:35       ` Tom Rini
     [not found] ` <161832721269.562320.7735221436131924903.stgit@localhost>
2021-04-14 19:37   ` [PATCH 01/13] pci: Update the highest subordinate bus number for bridge setup Simon Glass
2021-04-15 15:06     ` Tim Harvey
2021-04-16  0:14       ` Masami Hiramatsu
2021-04-16  0:21         ` Tim Harvey
2021-04-16  8:51           ` Masami Hiramatsu
     [not found] ` <161832727900.562320.2865719006692739168.stgit@localhost>
2021-04-14 19:37   ` [PATCH 02/13] ata: ahci-pci: Use scsi_ops to initialize ops Simon Glass
     [not found] ` <161832734602.562320.10889834449796156249.stgit@localhost>
2021-04-14 19:37   ` [PATCH 03/13] dm: pci: Skip setting VGA bridge bits if parent device is the host bus Simon Glass
2021-04-14 22:30     ` Bin Meng [this message]
2021-04-15  2:59       ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmVcJygMFB9LSfsuCfBqZO+To6aCioNqpVd04be1e-fk-Q@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.