All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] zynq-gem: Use appropriate cache flush/invalidate for RX and TX
Date: Thu, 13 Dec 2018 23:31:53 +0800	[thread overview]
Message-ID: <CAEUhbmVdQef5L+tGqBQA0tTd=uAsQQRp3HNNJ0YZzPLsi2tgEA@mail.gmail.com> (raw)
In-Reply-To: <20181213143752.11974-1-stefan.theil@mixed-mode.de>

On Thu, Dec 13, 2018 at 10:39 PM Stefan Theil
<stefan.theil@mixed-mode.de> wrote:
>
> The cache was only flushed before *transmitting* packets, but not

nits: but not invalidated

> when receiving them, leading to an issue where new packets were
> handed to the receive handler with old contents in cache. This
> only happens when a lot of packets are received without sending
> packages every now and then. Also flushing the receive buffers
> in the transmit function makes no sense and can be removed.
>
> Signed-off-by: Stefan Theil <stefan.theil@mixed-mode.de>
>
> ---
> Changes for v2:
>         - Use invalidate_dcache_range instead of
>           flush_dcache_range
> Changes for v3:
>         - Remove unnecessary flushing of all RX
>           buffers in zynq_gem_send
> ---
>  drivers/net/zynq_gem.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

      reply	other threads:[~2018-12-13 15:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[U-Boot] [PATCH v2] zynq-gem: Flush cache before handing RX packet to receive handler>
2018-12-13 14:37 ` [U-Boot] [PATCH v3] zynq-gem: Use appropriate cache flush/invalidate for RX and TX Stefan Theil
2018-12-13 15:31   ` Bin Meng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmVdQef5L+tGqBQA0tTd=uAsQQRp3HNNJ0YZzPLsi2tgEA@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.