From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Mon, 11 Feb 2019 11:21:25 +0800 Subject: [U-Boot] [PATCH v6 05/16] riscv: Add place-holder asm/arch/clk.h for driver compilation In-Reply-To: <20190209063052.29092-6-anup.patel@wdc.com> References: <20190209063052.29092-1-anup.patel@wdc.com> <20190209063052.29092-6-anup.patel@wdc.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, Feb 9, 2019 at 2:31 PM Anup Patel wrote: > > Some of the drivers expect asm/arch/clk.h to be provided by > arch support code so we add place-holder asm/arch/clk.h for > RISC-V support. > > Signed-off-by: Anup Patel > --- > arch/riscv/include/asm/arch/clk.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 arch/riscv/include/asm/arch/clk.h I looked at this and understand why patch [1/16] and [2/16] are needed. But can we do the same like other architectures, ie: creating directory include/asm/arch-xxx instead? Creating a hard-coded include/asm/arch directory prevents us from expanding SoC/platform specific support in the future. > > diff --git a/arch/riscv/include/asm/arch/clk.h b/arch/riscv/include/asm/arch/clk.h > new file mode 100644 > index 0000000000..1631f5f0bd > --- /dev/null > +++ b/arch/riscv/include/asm/arch/clk.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Copyright (c) 2019 Western Digital Corporation or its affiliates. > + * > + * Authors: > + * Anup Patel > + */ > + > +#ifndef __ASM_RISCV_ARCH_CLK_H > +#define __ASM_RISCV_ARCH_CLK_H > + > +/* Note: This is a placeholder header for driver compilation. */ > + > +#endif > -- Regards, Bin