All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] x86: efi: payload: Correct BITS_PER_LONG to 32
Date: Thu, 25 Aug 2016 10:56:06 +0800	[thread overview]
Message-ID: <CAEUhbmVni5O3E-OUVS9PmoaDOBUnu5i9z2tE_YNpcCfj+vPgPA@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ05EaJgKTj9EOcFqeYvuZrdH+z7vWnBaZc-DQ8283X+AQ@mail.gmail.com>

On Wed, Aug 24, 2016 at 8:53 PM, Simon Glass <sjg@chromium.org> wrote:
> On 24 August 2016 at 03:31, Bin Meng <bmeng.cn@gmail.com> wrote:
>> U-Boot itself as EFI payload is still running in 32-bit mode.
>> So BITS_PER_LONG should still be 32. This fixes the warnings
>> when building EFI 64-bit payload.
>>
>> include/asm-generic/bitops/__fls.h:17:2:
>>   warning: left shift count >= width of type
>>         if (!(word & (~0ul << 32))) {
>>                         ^
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>>  arch/x86/include/asm/types.h | 4 ----
>>  lib/efi/efi_stub.c           | 1 -
>>  2 files changed, 5 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Sorry this patch needs rework as 64-bit payload does not boot. I will
work on a v2.

Regards,
Bin

  reply	other threads:[~2016-08-25  2:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24  9:31 [U-Boot] [PATCH 1/3] x86: efi: payload: Make efi payload build again Bin Meng
2016-08-24  9:31 ` [U-Boot] [PATCH 2/3] x86: efi: payload: Correct BITS_PER_LONG to 32 Bin Meng
2016-08-24 12:53   ` Simon Glass
2016-08-25  2:56     ` Bin Meng [this message]
2016-08-24  9:31 ` [U-Boot] [PATCH 3/3] x86: qemu: efi: Add two boards for EFI 32-bit and 64-bit payload Bin Meng
2016-08-24 12:54   ` Simon Glass
2016-08-24 12:53 ` [U-Boot] [PATCH 1/3] x86: efi: payload: Make efi payload build again Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmVni5O3E-OUVS9PmoaDOBUnu5i9z2tE_YNpcCfj+vPgPA@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.