From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Mon, 1 Feb 2021 15:25:26 +0800
Subject: [PATCH v3 12/12] smbios: Allow a few values to come from sysinfo
In-Reply-To: <20210124174331.3462226-5-sjg@chromium.org>
References: <20210124174331.3462226-1-sjg@chromium.org>
 <20210124174331.3462226-5-sjg@chromium.org>
Message-ID: <CAEUhbmVuTqd-Yzuqm2oVAhgsBCWn3rxO7k8C0tRk5wJcApv=3Q@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On Mon, Jan 25, 2021 at 1:51 AM Simon Glass <sjg@chromium.org> wrote:
>
> While static configuration is useful it cannot cover every case. Sometimes
> board revisions are encoded in resistor straps and must be read at
> runtime.
>
> The easiest way to provide this information is via sysinfo, since the
> board can then provide a driver to read whatever is needed.
>
> Add some standard sysinfo options for this, and use them to obtain the
> required information.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
>

I guess you used patman to automatically collect the Reviewed-by tag?

Is this blank line inserted by patman? If yes, we should fix patman to
avoid this.

> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v3:
> - Use SMBIOS_STR_MAX for the max sysinfo string length
>
>  include/sysinfo.h | 11 +++++++++++
>  lib/smbios.c      | 32 +++++++++++++++++++++++++++++---
>  2 files changed, 40 insertions(+), 3 deletions(-)
>

Regards,
Bin