From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB2ACC433F5 for ; Sat, 18 Sep 2021 06:55:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0E4861260 for ; Sat, 18 Sep 2021 06:55:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F0E4861260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BEDF48325E; Sat, 18 Sep 2021 08:55:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UMJfiy9Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4CDA18325B; Sat, 18 Sep 2021 08:55:15 +0200 (CEST) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F25F88324A for ; Sat, 18 Sep 2021 08:55:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-qk1-x72f.google.com with SMTP id c10so24633698qko.11 for ; Fri, 17 Sep 2021 23:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0AxdXJNyzSsj86y95f39xFvI461fxlhVYqE8SjoaVOA=; b=UMJfiy9YWP/M4vvVGWuzmN6O3wggODyy6cZByuuFEAYUpoUC2ZW1OitGmRL27lnK9+ 1eGbeo/jAck6ORYmsln32oUy0okz5ifn+C4/Vw9cIfLaVZEa7UpoJRpLuwVpBffDj7bH YvnVC11rR+D+Ftq0MarQGHOkq3Dwtprm8CaSzvuWY1MsCgiBvxklfjYD0sT5FVMtfAhA 6FzYS/5PCFwtIqzRbhTBlvlAWVac63WjCXifJdOCAHic/U//R0b1rtA9qacD+1ZvvW9r 6XOIES5Aa9FXbjTBzE3HAXk4OK0ZCTa4eueedKodAkRhRfefjPNnpaSlE+vw4p6piRqh SJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0AxdXJNyzSsj86y95f39xFvI461fxlhVYqE8SjoaVOA=; b=lUgmPtIOdj6V7vHP6Uw6eqEiBoUWaRmq9frOb7cKseaJEpvRehnJVsBgqWV3i17viK bxg0uTqlK63HxU/aWTSn71q8lmnEuhRHVBNgwDfFcyRwoIq0NF8CzG1/jn5AuVS0xaar N9CUwjs2wNx0m0waNV41QTHZZvKC4fbQXS4ZB1sC4eQY6K8D5jagRLKNKWj/bHBBnupl KUrtKX0Hc70AWgUpwGAOg80z6+g52FHiLE7s8gjxIcXhBgYyd6vkj7RHQb/tVSgw5rjg j5/RaXqASHFF4GCNeTdK2KRBlXhBCLDvvSSP8QTlrrLUeUJdNNrD1JlslNY6llFTgOyP Bpeg== X-Gm-Message-State: AOAM532FdySyAmm/Rr06dgpIIFCp5BXVxhwLoCfkKJMaxU1r3P4nuk1e Trlr+0DzH34HfXhTxUkrSAB9qECQwmbXLWHTDss= X-Google-Smtp-Source: ABdhPJw60FwhTFCbcj3J2tdG3Zyw6ko3hZ7MP3zFAjrFfqo+BXbZ1s9qWmbjx+Pe7g9q/wD8xna/YGjvLmCvhMBL8AE= X-Received: by 2002:a25:80d4:: with SMTP id c20mr17450070ybm.345.1631948108570; Fri, 17 Sep 2021 23:55:08 -0700 (PDT) MIME-Version: 1.0 References: <20210917121130.526216-1-vladimir.oltean@nxp.com> <20210917121130.526216-2-vladimir.oltean@nxp.com> In-Reply-To: <20210917121130.526216-2-vladimir.oltean@nxp.com> From: Bin Meng Date: Sat, 18 Sep 2021 14:54:56 +0800 Message-ID: Subject: Re: [PATCH 01/11] pci: provide prototype for pci_skip_dev outside of #if defined(CONFIG_DM_PCI_COMPAT) To: Vladimir Oltean Cc: U-Boot Mailing List , Tom Rini , Priyanka Jain , Hou Zhiqiang Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Sep 17, 2021 at 8:11 PM Vladimir Oltean wrote: > > The weak definition of pci_skip_dev from drivers/pci/pci_common.c is not > under CONFIG_DM_PCI_COMPAT, and that definition needs a previous > function prototype declaration to avoid W=1 build warnings. > > That prototype is not available due to it being under CONFIG_DM_PCI_COMPAT, > so move it outside of that preprocessor block. > > Signed-off-by: Vladimir Oltean > --- > include/pci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng