All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dm: Add a debug message when devices are skipped pre-reloc
@ 2019-12-25  4:52 Sean Anderson
  2020-01-03 14:38 ` Bin Meng
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Sean Anderson @ 2019-12-25  4:52 UTC (permalink / raw)
  To: u-boot

This adds a message to lists_bind_fdt when it skips initializing a device
pre-relocation. I've had a couple errors where a device didn't initialize
properly because one of its dependencies was missing.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
---
 drivers/core/lists.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/core/lists.c b/drivers/core/lists.c
index 4681b3e5dd..68204c303f 100644
--- a/drivers/core/lists.c
+++ b/drivers/core/lists.c
@@ -176,8 +176,10 @@ int lists_bind_fdt(struct udevice *parent, ofnode node, struct udevice **devp,

 		if (pre_reloc_only) {
 			if (!dm_ofnode_pre_reloc(node) &&
-			    !(entry->flags & DM_FLAG_PRE_RELOC))
+			    !(entry->flags & DM_FLAG_PRE_RELOC)) {
+				log_debug("Skipping device pre-relocation\n");
 				return 0;
+			}
 		}

 		log_debug("   - found match at '%s': '%s' matches '%s'\n",
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] dm: Add a debug message when devices are skipped pre-reloc
  2019-12-25  4:52 [PATCH] dm: Add a debug message when devices are skipped pre-reloc Sean Anderson
@ 2020-01-03 14:38 ` Bin Meng
  2020-01-07 16:49 ` Simon Glass
  2020-01-10  8:57 ` sjg at google.com
  2 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2020-01-03 14:38 UTC (permalink / raw)
  To: u-boot

On Wed, Dec 25, 2019 at 12:52 PM Sean Anderson <seanga2@gmail.com> wrote:
>
> This adds a message to lists_bind_fdt when it skips initializing a device
> pre-relocation. I've had a couple errors where a device didn't initialize
> properly because one of its dependencies was missing.
>
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
>  drivers/core/lists.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] dm: Add a debug message when devices are skipped pre-reloc
  2019-12-25  4:52 [PATCH] dm: Add a debug message when devices are skipped pre-reloc Sean Anderson
  2020-01-03 14:38 ` Bin Meng
@ 2020-01-07 16:49 ` Simon Glass
  2020-01-10  8:57 ` sjg at google.com
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2020-01-07 16:49 UTC (permalink / raw)
  To: u-boot

On Tue, 24 Dec 2019 at 21:52, Sean Anderson <seanga2@gmail.com> wrote:
>
> This adds a message to lists_bind_fdt when it skips initializing a device
> pre-relocation. I've had a couple errors where a device didn't initialize
> properly because one of its dependencies was missing.
>
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
>  drivers/core/lists.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] dm: Add a debug message when devices are skipped pre-reloc
  2019-12-25  4:52 [PATCH] dm: Add a debug message when devices are skipped pre-reloc Sean Anderson
  2020-01-03 14:38 ` Bin Meng
  2020-01-07 16:49 ` Simon Glass
@ 2020-01-10  8:57 ` sjg at google.com
  2 siblings, 0 replies; 4+ messages in thread
From: sjg at google.com @ 2020-01-10  8:57 UTC (permalink / raw)
  To: u-boot

On Tue, 24 Dec 2019 at 21:52, Sean Anderson <seanga2@gmail.com> wrote:
>
> This adds a message to lists_bind_fdt when it skips initializing a device
> pre-relocation. I've had a couple errors where a device didn't initialize
> properly because one of its dependencies was missing.
>
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
>  drivers/core/lists.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-10  8:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-25  4:52 [PATCH] dm: Add a debug message when devices are skipped pre-reloc Sean Anderson
2020-01-03 14:38 ` Bin Meng
2020-01-07 16:49 ` Simon Glass
2020-01-10  8:57 ` sjg at google.com

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.