From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Mon, 3 Aug 2020 12:26:01 +0800
Subject: master u-boot broken for HiFive Unleashed
In-Reply-To: <CAOnJCUKc1k9k4VSEEyM8NrK_AKvdqV0nS6eGh7u-BHjTeNQJ=w@mail.gmail.com>
References: <CAOnJCUKc1k9k4VSEEyM8NrK_AKvdqV0nS6eGh7u-BHjTeNQJ=w@mail.gmail.com>
Message-ID: <CAEUhbmW7xP+8-nj7q93bg+EDyTrGP0RfZ+Ro=8CJc92Svi7BqA@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Atish,

On Thu, Jul 30, 2020 at 5:43 AM Atish Patra <atishp@atishpatra.org> wrote:
>
> Hi,
> The latest master (423e08cb7701 (origin/master, origin/HEAD) Merge
> branch '2020-07-28-misc-soc-improvements') seems to be broken for
> HiFive Unleashed.
>
> It already has Bin's fix for unleashed.
>
> a0018fc8209c riscv: Make SiFive HiFive Unleashed board boot again
>
> dram start and size is corrupted for some reason. I have verified that
> it was initialized properly during DT parsing. However, it shows
> random values in the U-Boot console.
>
> => bdinfo
> boot_params = 0x0000000000000000
> memstart    = 0x0000000000000000
> memsize     = 0x00000000
> flashstart  = 0x0000000000000000
> flashsize   = 0x0000000000000000
> flashoffset = 0x0000000000000000
> baudrate    = 115200 bps
> relocaddr   = 0x00000000fff84000
> reloc off   = 0x000000007fd84000
> Build       = 64-bit
>
> => bdinfo
> boot_params = 0x9a26a361c16aa601
> DRAM bank   = 0x0000000000000000
> -> start    = 0x974515c3bda965ef
> -> size     = 0x79b6f0fb37923036
> memstart    = 0x574587c7f00570f9
> memsize     = 0xCFD8C0F4D42668AB
> flashstart  = 0x67f9fbb06586658b
> flashsize   = 0xf91aed913c99b9e1
> flashoffset = 0x9ddbf00d69e870fa
> baudrate    = 115200 bps
>
> v2020.07 seems to work fine. I couldn't bisect between those two as
> the number of commits didn't compile.

I cannot reproduce this. See below log:

U-Boot SPL 2020.10-rc1-00172-ga2d051e (Aug 03 2020 - 12:22:07 +0800)
Trying to boot from MMC1


U-Boot 2020.10-rc1-00172-ga2d051e (Aug 03 2020 - 12:22:07 +0800)

CPU:   rv64imafdc
Model: SiFive HiFive Unleashed A00
DRAM:  8 GiB
MMC:   spi at 10050000:mmc at 0: 0
Loading Environment from SPIFlash... SF: Detected is25wp256 with page
size 256 Bytes, erase size 4 KiB, total 32 MiB
OK
In:    serial at 10010000
Out:   serial at 10010000
Err:   serial at 10010000
Net:   eth0: ethernet at 10090000
Hit any key to stop autoboot:  0
=>
=> bdinfo
boot_params = 0x0000000000000000
DRAM bank   = 0x0000000000000000
-> start    = 0x0000000080000000
-> size     = 0x0000000200000000
memstart    = 0x0000000000000000
memsize     = 0x00000000
flashstart  = 0x0000000000000000
flashsize   = 0x0000000000000000
flashoffset = 0x0000000000000000
baudrate    = 115200 bps
relocaddr   = 0x00000000fff83000
reloc off   = 0x000000007fd83000
Build       = 64-bit
current eth = ethernet at 10090000
ethaddr     = 70:b3:d5:92:f2:51
IP addr     = 128.224.159.129
fdt_blob    = 0x00000000ff75c4a0
new_fdt     = 0x00000000ff75c4a0
fdt_size    = 0x0000000000006980

=>

I built U-Boot from the latest u-boot/master:

commit a2d051e7b6a8f87add1067d936bb0c805a47b0df
Merge: 719f421 db82015
Author: Tom Rini <trini@konsulko.com>
Date:   Fri Jul 31 10:13:07 2020 -0400

    Merge branch '2020-07-31-more-env-updates'

    - Fix EFI selftest to not force setting serial# environment (and also
      get the U-Boot prompt dynamically).
    - Support for append only environment and other related features.
    - Improved ext4 environment support
    - Fix the case of fw_setenv being used on flash devices that were not
      already locked.

Regards,
Bin