Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID

From: Bin Meng <bmeng.cn@gmail.com>
To: tekkamanv@163.com
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Jagan Teki <jagan@amarulasolutions.com>,
	 Vignesh R <vigneshr@ti.com>,
	tekkamanv@starfivetech.com, tekkamanninja@163.com,
	"yanhong.wang" <yanhong.wang@starfivetech.com>
Subject: Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID
Date: Sat, 2 Oct 2021 22:15:27 +0800	[thread overview]
Message-ID: <CAEUhbmWDfJMB98QuJMGzCuSg6U7DOtVB505SAtMqWCyb2UXOUw@mail.gmail.com> (raw)
In-Reply-To: <20210930105329.438730-1-tekkamanv@163.com>

On Thu, Sep 30, 2021 at 6:55 PM <tekkamanv@163.com> wrote:
>
> From: "yanhong.wang" <yanhong.wang@starfivetech.com>
>

Please add a brief commit message for this, like providing a datasheet
for reference:

https://www.gigadevice.com/datasheet/gd25lq256d/

> Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>

I believe the name should be spelled as "Yanhong Wang"

> ---
>  drivers/mtd/spi/spi-nor-ids.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 4aef1ddd6e..35fa347c44 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -122,6 +122,11 @@ const struct flash_info spi_nor_ids[] = {
>                         SECT_4K | SPI_NOR_DUAL_READ |
>                         SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>         },
> +       {
> +               INFO("gd25lq256d", 0xc86019, 0, 64 * 1024, 512,
> +                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +       },
>  #endif
>  #ifdef CONFIG_SPI_FLASH_ISSI           /* ISSI */
>         /* ISSI */

Otherwise LGTM:
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>