All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: Leo Liang <ycliang@andestech.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/1] doc: riscv: flashing SiFive boards
Date: Mon, 2 Aug 2021 17:01:07 +0800	[thread overview]
Message-ID: <CAEUhbmWK-H0eV9k4MHz-445pDxjKjyzvyvkt3Gmuqs3kVRVq7Q@mail.gmail.com> (raw)
In-Reply-To: <20210802085041.GC3588@andestech.com>

Hi Leo,

On Mon, Aug 2, 2021 at 4:50 PM Leo Liang <ycliang@andestech.com> wrote:
>
> Hi Bin,
>
> On Wed, Jul 28, 2021 at 05:18:59PM +0800, Bin Meng wrote:
> > On Wed, Jul 28, 2021 at 5:03 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> > >
> >
> > nits: missing
>
> Could you explain what is missing here?
> I did not quite catch the point, thanks!
>

Missing the 2nd line I mentioned in my previous email:

From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

> >
> > From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> >
> > > We should not use /dev/sda and /dev/sdb in our examples. Users might
> > > inadvertently mess up their workstation. Use /dev/sdX instead.
> > >
> > > Remove console output like '# ' and '> ' which makes copying hard.
> > >
> > > Set example language to bash for correct syntax-highlighting.
> > >
> > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > > ---
> > >  doc/board/sifive/unleashed.rst | 20 ++++++++++----------
> > >  doc/board/sifive/unmatched.rst | 30 +++++++++++++++---------------
> > >  2 files changed, 25 insertions(+), 25 deletions(-)
> > >
> >
> > Otherwise
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin

  reply	other threads:[~2021-08-02  9:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28  9:03 [PATCH 1/1] doc: riscv: flashing SiFive boards Heinrich Schuchardt
2021-07-28  9:18 ` Bin Meng
2021-08-02  8:50   ` Leo Liang
2021-08-02  9:01     ` Bin Meng [this message]
2021-08-02  9:17       ` Leo Liang
2021-08-02  9:48         ` Bin Meng
2021-08-02 10:20           ` Leo Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmWK-H0eV9k4MHz-445pDxjKjyzvyvkt3Gmuqs3kVRVq7Q@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.