From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Mon, 11 Jan 2016 11:10:22 +0800
Subject: [U-Boot] [PATCH 0/8] arm: ls1021atwr: Convert to driver model
 and enable serial support
In-Reply-To: <CAEUhbmWRoLyU58qJksBA4j3zYgdZkpNdpxpeUnte1HZeECeewQ@mail.gmail.com>
References: <1451551990-32165-1-git-send-email-bmeng.cn@gmail.com>
 <VI1PR04MB1600F89FB44E101E87B0E30EF4F40@VI1PR04MB1600.eurprd04.prod.outlook.com>
 <CAEUhbmXGpHjrgYm-6mMdhnA1eu=_4a3hg3Y4in8fLpEPX1zc7Q@mail.gmail.com>
 <VI1PR04MB1600BD753418C7DB5CE92A60F4F50@VI1PR04MB1600.eurprd04.prod.outlook.com>
 <CAEUhbmWuYtPRg_W1aWC5pnuv57ibvA_fuDpXL-OdAC+d8CbpGg@mail.gmail.com>
 <VI1PR04MB1600470167880EAE2A877A86F4F50@VI1PR04MB1600.eurprd04.prod.outlook.com>
 <CAEUhbmWRoLyU58qJksBA4j3zYgdZkpNdpxpeUnte1HZeECeewQ@mail.gmail.com>
Message-ID: <CAEUhbmWK7CD6DFZYCOqeSOGf6hu3=wTRK1AhmDqcVBao9=edeA@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On Thu, Jan 7, 2016 at 5:22 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Alison,
>
> On Thu, Jan 7, 2016 at 2:19 PM, Huan Wang <alison.wang@nxp.com> wrote:
>> Hi, Bin,
>>
>>> On Thu, Jan 7, 2016 at 2:01 PM, Huan Wang <alison.wang@nxp.com> wrote:
>>> > Hi, Bin,
>>> >
>>> >> On Wed, Jan 6, 2016 at 1:31 PM, Huan Wang <alison.wang@nxp.com> wrote:
>>> >> > Hi,
>>> >> >
>>> >> >         I tested this set on my LS1021ATWR board. NOR boot using
>>> >> > DUART
>>> >> as serial output is ok. But NOR boot using LPUART as serial output
>>> >> failed. How about your test result?
>>> >> >
>>> >>
>>> >> Yes, I tested NOR boot using DUART or LPUART. Both boot. I suspect
>>> >> you forgot to update the RCW for LPUART, or change the jumper setting
>>> >> (J19,
>>> >> J20) to route the LPUART signal.
>>> >>
>>> > [Alison Wang] I updated the RCW for LPUART and changed the jumper
>>> > setting (J19, J20). Without this set, NOR boot using LPUART is ok. But
>>> > after adding this set, NOR boot using LPUART failed.
>>> >
>>>
>>> That's strange. Can you please send your build instructions? Did you
>>> program the u-boot-dtb.bin (not u-boot.bin anymore) to the NOR?
>>>
>> [Alison Wang] My build instructions are,
>>
>> make ARCH=arm ls1021atwr_nor_lpuart_defconfig
>> make
>>
>> Yes. I programmed u-boot-dtb.bin to NOR flash.
>>
>
> Oh, it turns out the last thing to suspect is the /chose node :)
>
> See comments in patch#8 in this series
> (http://patchwork.ozlabs.org/patch/561859/)
>
>   chosen {
> + /*
> + * With ls1021atwr_nor_lpuart_defconfig configuration,
> + * this needs to be changed to &lpuart0.
> + */
>   stdout-path = &uart0;
>   };
>
> I was wondering whether I should introduce another separate dts file
> for this LPUART configuration, something like ls1021a-twr_lpuart.dts,
> but I felt it's quite some duplication thus I chose to just add some
> comments under the /chosen node in the original dts file.
>
> I've done the PCI UART support on the Crown Bay before using the same
> way. Simon, do you have some better way to handle this?

Alison has tested this series on her board. I believe the only concern
is with the lpuart in the /chosen node. Can you comment on this?

Regards,
Bin