From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Tue, 30 Jan 2018 22:42:51 +0800
Subject: [U-Boot] [PATCH] x86: kconfig: Remove meaningless 'select n'
In-Reply-To: <CAEUhbmWzKbPxVqQdrmtFSpOCnxgrPzBht2=2EzMVCKSOz87-HA@mail.gmail.com>
References: <20180130125903.5920-1-ulfalizer@gmail.com>
 <CAEUhbmWzKbPxVqQdrmtFSpOCnxgrPzBht2=2EzMVCKSOz87-HA@mail.gmail.com>
Message-ID: <CAEUhbmWLKnYFQC7mHSLHwtPX261pvAPHzp_v3aEN0EZ+NAGofw@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, Jan 30, 2018 at 9:04 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Tue, Jan 30, 2018 at 8:59 PM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
>> 'select n' selects a constant symbol, which is meaningless and has no
>> effect. Maybe this was meant to be a 'default n', though bool and
>> tristate symbols already implicitly default to n.
>>
>> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
>> which does more strict checking here:
>>
>>         kconfiglib.KconfigSyntaxError: board/google/Kconfig:34: Couldn't parse '        select n': expected nonconstant symbol
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>> ---
>>  board/google/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
>>
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!