From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Wed, 8 Jul 2020 12:07:24 +0800 Subject: [PATCH v1 02/43] binman: Refactor binman_entry_find() to allow other nodes In-Reply-To: References: <20200615035738.248710-1-sjg@chromium.org> <20200615035738.248710-3-sjg@chromium.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de +Tom, On Wed, Jul 8, 2020 at 10:23 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 29 Jun 2020 at 20:33, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Jun 15, 2020 at 11:57 AM Simon Glass wrote: > > > > > > At present we can only read from a top-level binman node entry. Refactor > > > this function to produce a second local function which supports reading > > > from any node. > > > > > > Signed-off-by: Simon Glass > > > --- > > > > > > lib/binman.c | 18 ++++++++++++------ > > > 1 file changed, 12 insertions(+), 6 deletions(-) > > > > > > diff --git a/lib/binman.c b/lib/binman.c > > > index dc3a880882..79d01230dd 100644 > > > --- a/lib/binman.c > > > +++ b/lib/binman.c > > > @@ -29,25 +29,31 @@ struct binman_info { > > > > > > static struct binman_info *binman; > > > > > > -int binman_entry_find(const char *name, struct binman_entry *entry) > > > +int binman_entry_find_(ofnode node, const char *name, struct binman_entry *entry) > > > > This one should be static. We really should agree on a naming > > convention for such internal APIs. I would prefer adding _internal > > suffix, or using __ prefix > > Well I think internal is too long and I like a trailing underscore. > The trailing underscore is easy to be misread. > The trailing double underscore is reserved for the compiler. > What I prefer is the leading double underscore which I think is allowed. > Another option is to drop the prefix, so: > > find_entry(...) Regards, Bin