From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB7FBC3DA79 for ; Mon, 26 Dec 2022 13:56:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p9nxw-0005PH-E0; Mon, 26 Dec 2022 08:56:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9nxu-0005Oj-9K; Mon, 26 Dec 2022 08:56:30 -0500 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p9nxs-0006RH-DE; Mon, 26 Dec 2022 08:56:30 -0500 Received: by mail-ej1-x62b.google.com with SMTP id t17so26169674eju.1; Mon, 26 Dec 2022 05:56:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qMpQeKq6lJb+km05pe2QjU0RqXRacq9OI/4e/fyKWN4=; b=fLMT0c8x3jzry4Sb58Q36s5KJRDGNwQvRuKYTUdI/fryVioOBPe73kmOR1f9ADFLcr CKIJ75A/gu5vfGFsgwjk1tKv0UxilmbwqHRqoR8v9xeg7GUwNUeVsTcENy2lG+rBVVAC oFIDAfAlsCo/GvRoqj3AbbkTCpPWkO879ZO87l7Q6X5hXTErAHjPIqTB4MxxkkyraVWg kk6sLoDjogwp1+SPo6AzVIWKkXO9uaFkTveLa5ygXI8Pi8y5cNvGqym1njv7bq/tEVaD AGqytC5ibasoQVEWYzv08xbU8/3gb7/jvZkNBGk1Q0HcFmpAwMbIUvqOU41+e+0aPOhI 3zDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qMpQeKq6lJb+km05pe2QjU0RqXRacq9OI/4e/fyKWN4=; b=0d/3LAJh/hAXCuhyehv6S53niDUfjdXnOqlZouiItOpfn81uOITl8DTxHTN8EnE1et stq+nT7iJdDAZzgCGmvms2IsAq9xwvBVEVFf4JbxmnPvZfRZTYRFH+EbAADhzN/vnH7v PWqHUkbN0htDs7kLW+NyLAtZk4RYG9hvUSCD5yzTAZxqMQytF5GOBPFT2PZ3kmFQxpF0 8GZ5Q7yWCApH4x8DmX283c+qvT1Yoz5r6izd4yWEaNU4RFv1/HLt+XZDK4UfBDaele6W TCTLuuTjOcQwkhBqxfzar5pIn1Kjp2LtGDLcT2KzJE2Tow42XyaHGc6PznD0vr9WQAgX Yg8A== X-Gm-Message-State: AFqh2krcW4B+AbXo1VMB5G+9qcn1k57KHfwQuFoIw1oFTTFjnsCu7Wf2 AhfJ2tySskgA+yatN7Hol5/Z9Ol9lXEgBcSKtd0= X-Google-Smtp-Source: AMrXdXv3yIMGx+vAAYVLJ5yurM6JYYdkxM8xapFqbu6GinU7tS0HGV2ywhpqsznk5VM8VtqykTYvy8cwlAlzyMFkYz0= X-Received: by 2002:a17:906:1945:b0:7c0:bb4c:e792 with SMTP id b5-20020a170906194500b007c0bb4ce792mr1407392eje.618.1672062986317; Mon, 26 Dec 2022 05:56:26 -0800 (PST) MIME-Version: 1.0 References: <20221221182300.307900-1-dbarboza@ventanamicro.com> <20221221182300.307900-2-dbarboza@ventanamicro.com> In-Reply-To: From: Bin Meng Date: Mon, 26 Dec 2022 21:56:14 +0800 Message-ID: Subject: Re: [PATCH 01/15] tests/avocado: add RISC-V opensbi boot test To: Anup Patel , Alistair Francis Cc: Daniel Henrique Barboza , Anup Patel , qemu-devel@nongnu.org, qemu-riscv@nongnu.org, Bin Meng , Cleber Rosa , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=bmeng.cn@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, Dec 24, 2022 at 11:52 AM Bin Meng wrote: > > Hi, > > On Fri, Dec 23, 2022 at 2:25 PM Bin Meng wrote: > > > > Hi Anup, > > > > On Fri, Dec 23, 2022 at 12:56 AM Anup Patel wrote= : > > > > > > On Thu, Dec 22, 2022 at 6:27 PM Bin Meng wrote: > > > > > > > > On Thu, Dec 22, 2022 at 6:47 PM Daniel Henrique Barboza > > > > wrote: > > > > > > > > > > > > > > > > > > > > On 12/22/22 07:24, Bin Meng wrote: > > > > > > On Thu, Dec 22, 2022 at 2:29 AM Daniel Henrique Barboza > > > > > > wrote: > > > > > >> This test is used to do a quick sanity check to ensure that we= 're able > > > > > >> to run the existing QEMU FW image. > > > > > >> > > > > > >> 'sifive_u', 'spike' and 'virt' riscv64 machines, and 'sifive_u= ' and > > > > > >> 'virt' 32 bit machines are able to run the default RISCV64_BIO= S_BIN | > > > > > >> RISCV32_BIOS_BIN firmware with minimal options. > > > > > >> > > > > > >> Cc: Cleber Rosa > > > > > >> Cc: Philippe Mathieu-Daud=C3=A9 > > > > > >> Cc: Wainer dos Santos Moschetta > > > > > >> Cc: Beraldo Leal > > > > > >> Signed-off-by: Daniel Henrique Barboza > > > > > >> --- > > > > > >> tests/avocado/riscv_opensbi.py | 65 ++++++++++++++++++++++++= ++++++++++ > > > > > >> 1 file changed, 65 insertions(+) > > > > > >> create mode 100644 tests/avocado/riscv_opensbi.py > > > > > >> > > > > > >> diff --git a/tests/avocado/riscv_opensbi.py b/tests/avocado/ri= scv_opensbi.py > > > > > >> new file mode 100644 > > > > > >> index 0000000000..abc99ced30 > > > > > >> --- /dev/null > > > > > >> +++ b/tests/avocado/riscv_opensbi.py > > > > > >> @@ -0,0 +1,65 @@ > > > > > >> +# opensbi boot test for RISC-V machines > > > > > >> +# > > > > > >> +# Copyright (c) 2022, Ventana Micro > > > > > >> +# > > > > > >> +# This work is licensed under the terms of the GNU GPL, versi= on 2 or > > > > > >> +# later. See the COPYING file in the top-level directory. > > > > > >> + > > > > > >> +from avocado_qemu import QemuSystemTest > > > > > >> +from avocado_qemu import wait_for_console_pattern > > > > > >> + > > > > > >> +class RiscvOpensbi(QemuSystemTest): > > > > > >> + """ > > > > > >> + :avocado: tags=3Daccel:tcg > > > > > >> + """ > > > > > >> + timeout =3D 5 > > > > > >> + > > > > > >> + def test_riscv64_virt(self): > > > > > >> + """ > > > > > >> + :avocado: tags=3Darch:riscv64 > > > > > >> + :avocado: tags=3Dmachine:virt > > > > > >> + """ > > > > > >> + self.vm.set_console() > > > > > >> + self.vm.launch() > > > > > >> + wait_for_console_pattern(self, 'Platform Name') > > > > > >> + wait_for_console_pattern(self, 'Boot HART MEDELEG') > > > > > >> + > > > > > >> + def test_riscv64_spike(self): > > > > > >> + """ > > > > > >> + :avocado: tags=3Darch:riscv64 > > > > > >> + :avocado: tags=3Dmachine:spike > > > > > >> + """ > > > > > >> + self.vm.set_console() > > > > > >> + self.vm.launch() > > > > > >> + wait_for_console_pattern(self, 'Platform Name') > > > > > >> + wait_for_console_pattern(self, 'Boot HART MEDELEG') > > > > > >> + > > > > > >> + def test_riscv64_sifive_u(self): > > > > > >> + """ > > > > > >> + :avocado: tags=3Darch:riscv64 > > > > > >> + :avocado: tags=3Dmachine:sifive_u > > > > > >> + """ > > > > > >> + self.vm.set_console() > > > > > >> + self.vm.launch() > > > > > >> + wait_for_console_pattern(self, 'Platform Name') > > > > > >> + wait_for_console_pattern(self, 'Boot HART MEDELEG') > > > > > >> + > > > > > >> + def test_riscv32_virt(self): > > > > > >> + """ > > > > > >> + :avocado: tags=3Darch:riscv32 > > > > > >> + :avocado: tags=3Dmachine:virt > > > > > >> + """ > > > > > >> + self.vm.set_console() > > > > > >> + self.vm.launch() > > > > > >> + wait_for_console_pattern(self, 'Platform Name') > > > > > >> + wait_for_console_pattern(self, 'Boot HART MEDELEG') > > > > > > How about testing riscv32_spike too? > > > > > > > > > > > > > > > I didn't manage to make it work. This riscv64 spark command line = boots opensbi: > > > > > > > > > > > > > > > $ ./qemu-system-riscv64 -nographic -display none -vga none -machi= ne spike > > > > > > > > > > OpenSBI v1.1 > > > > > ____ _____ ____ _____ > > > > > / __ \ / ____| _ \_ _| > > > > > | | | |_ __ ___ _ __ | (___ | |_) || | > > > > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > > > > | |__| | |_) | __/ | | |____) | |_) || |_ > > > > > \____/| .__/ \___|_| |_|_____/|____/_____| > > > > > | | > > > > > |_| > > > > > > > > > > (...) > > > > > > > > > > The same command line doesn't boot riscv32 spark: > > > > > > > > > > ./qemu-system-riscv32 -nographic -display none -vga none -machine= spike > > > > > (--- hangs indefinitely ---) > > > > > > > > > > I debugged it a bit and, as far as boot code goes, it goes all th= e way and loads the > > > > > opensbi 32bit binary. > > > > > > > > > > After that I tried to found any command line example that boots s= pike with riscv32 > > > > > bit and didn't find any. So I gave up digging it further because= I became unsure > > > > > about whether 32-bit spike works. > > > > > > > > > > If someone can verify that yes, 32-bit spike is supposed to work,= then I believe it's > > > > > worth investigating why it's not the case ATM. > > > > > > > > > > > > > +Anup who might know if QEMU spike 32-bit machine works with opensb= i > > > > 32-bit generic image. > > > > > > We never got HTIF putc() working on QEMU RV32 Spike but it works > > > perfectly fine on QEMU RV64 Spike. > > > > Where is the problem for the 32-bit? Is it in OpenSBI or in QEMU? > > > > > > > > See below log of QEMU RV64 Spike ... > > > > > > > If we cannot get Spike 32-bit to work in QEMU, should we drop the > > 32-bit support? @Alistair Francis > > I got a deeper look at the 32-bit spike issue and I believe it is a > problem of QEMU HTIF emulation. > > I will see if I can spin a patch to fix this. > It turns out there is a bug in OpenSBI too when booting 32-bit BIN image on Spike. For ELF & BIN image boot on QEMU, QEMU changes are needed. I will send the QEMU patches soon. Regards, Bin