From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Subject: Re: [PATCH] riscv: dts: fu540-c000: Add "status" property to cpu node Date: Fri, 5 Jul 2019 13:11:01 +0800 Message-ID: References: <1562298766-25066-1-git-send-email-bmeng.cn@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane.org@lists.infradead.org To: Anup Patel Cc: Mark Rutland , devicetree , Albert Ou , Palmer Dabbelt , Yash Shah , Rob Herring , Paul Walmsley , linux-riscv List-Id: devicetree@vger.kernel.org On Fri, Jul 5, 2019 at 11:59 AM Anup Patel wrote: > > > > > -----Original Message----- > > From: linux-riscv On Behalf Of Bin > > Meng > > Sent: Friday, July 5, 2019 9:23 AM > > To: linux-riscv ; devicetree > > ; Rob Herring ; Mark > > Rutland ; Albert Ou ; > > Paul Walmsley ; Palmer Dabbelt > > ; Yash Shah > > Subject: [PATCH] riscv: dts: fu540-c000: Add "status" property to cpu node > > > > Per device tree spec, the "status" property property shall be present for > > nodes representing CPUs in a SMP configuration. This property is currently > > missing in cpu 1/2/3/4 node in the fu540-c000.dtsi. > > We don't need explicit "status = okay" for SOC internal devices > (such as PLIC, INTC, etc) which are always enabled by default. > Yes, that's fine because those device bindings do not require them. > Absence of "status" DT prop is treated as enabled by default. > But per current device tree spec, "status" in cpu node is mandatory. (spec uses "shall"). Missing it is a spec violation. Regards, Bin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A03B4C4649B for ; Fri, 5 Jul 2019 14:01:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6700B218CA for ; Fri, 5 Jul 2019 14:01:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nGDeC3eV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="KTPkNE+N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VH8WWlPY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6700B218CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RycFc5Dben0/cUWEEsrCCeZ1nYdjbbhjzmfHNT+YB1I=; b=nGDeC3eVoCIvJ/ 9ClmD5yrooNiEBjhhQHidK1kbNoa0YSsowwZs1kj+tHfsNjzeHlVYXk8Pr61kMswqV2i4a7N4aaAW v3y8ONF8fQUGe4sof4f5fJTT4KKVH1/JPYsrR1pQCYW8qHElRozjPHLAHl3ePOlosdx/hq87SsLCO yOSENubXN9ddYlxVnwlbE4ooLXL8y+ZxvR0W50mBHIFiFs5vjxHNjwOPdJnER9hsVa92VgLropPm2 T/VApBCzyO5PhfwtCHTMs+DeFdY3mZv13snlnI7UYmtCiQTAnMJwBNus0pdim1Q9wIq63lfoky8sd bw2pCYRfkT9/wysasRww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hjOmS-0005ib-5m; Fri, 05 Jul 2019 14:01:40 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjOfc-0004tI-6T for linux-riscv@bombadil.infradead.org; Fri, 05 Jul 2019 13:54:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:Cc:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5nGqMOGRrREtq0FFSgC4UXuJiabbKTxeO2VC6p8bpug=; b=KTPkNE+NuTUi38kmmYxIC/Sce FqooGxN+AF1JadwQCjpqxqF+f7BGKlG2WhQRQu7g16oSm7Ol4nrGQmIZgyMUrHzgFDJGsU90rvsl+ k+m4GCrL9wxeFECWMOk/Vqq/WAbAi8Cp7Rg5lMjYBngUmwJ9jPUboqk9tljuPdfHIGs0XD06DREv8 RFhetpSICudyAZgzLKKdR24cCXahvdiJso9VTB5HYPRDjhINKUk14IVJVA6GF+C0YyF0ihAcxErBd qgZCdW0L7h/iAhHB+0ZatjrU3bsB2XbiU/c45rwseYkLSkN67MLv52YWt6B2QN2QlmIMG7wQzbyBS APa7ebgTg==; Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by casper.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjGX9-0007ai-JI for linux-riscv@lists.infradead.org; Fri, 05 Jul 2019 05:13:21 +0000 Received: by mail-ed1-x544.google.com with SMTP id p15so7070357eds.8 for ; Thu, 04 Jul 2019 22:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5nGqMOGRrREtq0FFSgC4UXuJiabbKTxeO2VC6p8bpug=; b=VH8WWlPYo7hQxS/xuOa2+ppxz4qfV+ZRE8ktONXDASmv+Zs7MSDdjZlSMTlaAi8E2R tXnUsRrzMg43HKo8Dj2YmUJQ2Tvl5TViA8CmJ6p//374KNqRkdhYCVqcoN4cCcQRPP9o MS5JmPvBTRN5sI0MHYDULjJH3YPwyFk9SL+jFeA2C97VlB//pWN2T3F8ntuVvn2dRNDF PRt5LFuouTuJl7xT+ETi20L6OUpglyhvIc5Ba185ynFJrVKjkMYcdaddXHWp+Nfx9lto GMxohs5UlpWOrTW9edyBNzp1VqHeNxMaAVc7eIgXiwxAmryfXgIiYpDL8Do2U/dtqxz3 CO6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5nGqMOGRrREtq0FFSgC4UXuJiabbKTxeO2VC6p8bpug=; b=EYxyWKXgNNmWqaFphbueBlPDc38rQAIgWC9IMlWOa2I/eoWeC4AfZybivjEMKczLgr 1XLS8UVHeS+2OStIB5yOd7HcqJwA+GKtgtB7gLtlBnVchpFvzgvvaZH9hUFcLccPHIvE E1768845hlHyfipfar+mGzEr1yIMKRX0sPfxUZ4TJOyek0Sffmo0KE3dkEjV476OMq6l 0LO0bdaS3/U45OMv5pse3B4qf1bQorhnv55htnxXvwFeHmN5t2rz7gZmfBk21hlVdBB3 kAxLWL8g3VWdKCwlAoZaz6YZIO+IuK++8ri6PMkmBaT3L0kXnW6dV2BvxYtXtvEwJq7c hd7A== X-Gm-Message-State: APjAAAUzwO9voTMdH8r8QBPs/SGDbi6jBlZLuHsE4YIi41K6av38ZAjw PeHruZhpUPbXfsbIN4cfdi8S5+U6Cdkmi+4EhMg= X-Google-Smtp-Source: APXvYqwhEclyD5r/MuRZrPMCFY8QPPhwXUvp0u0r3Z4aoXRwYr7yxzjq8rl2+VmBwY8yKsqS4N/RxGQughfvw+qdUWQ= X-Received: by 2002:a17:906:fcb8:: with SMTP id qw24mr1572300ejb.239.1562303472975; Thu, 04 Jul 2019 22:11:12 -0700 (PDT) MIME-Version: 1.0 References: <1562298766-25066-1-git-send-email-bmeng.cn@gmail.com> In-Reply-To: From: Bin Meng Date: Fri, 5 Jul 2019 13:11:01 +0800 Message-ID: Subject: Re: [PATCH] riscv: dts: fu540-c000: Add "status" property to cpu node To: Anup Patel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190705_061319_683444_AD4B15CB X-CRM114-Status: GOOD ( 13.96 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Albert Ou , Palmer Dabbelt , Yash Shah , Rob Herring , Paul Walmsley , linux-riscv Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Jul 5, 2019 at 11:59 AM Anup Patel wrote: > > > > > -----Original Message----- > > From: linux-riscv On Behalf Of Bin > > Meng > > Sent: Friday, July 5, 2019 9:23 AM > > To: linux-riscv ; devicetree > > ; Rob Herring ; Mark > > Rutland ; Albert Ou ; > > Paul Walmsley ; Palmer Dabbelt > > ; Yash Shah > > Subject: [PATCH] riscv: dts: fu540-c000: Add "status" property to cpu node > > > > Per device tree spec, the "status" property property shall be present for > > nodes representing CPUs in a SMP configuration. This property is currently > > missing in cpu 1/2/3/4 node in the fu540-c000.dtsi. > > We don't need explicit "status = okay" for SOC internal devices > (such as PLIC, INTC, etc) which are always enabled by default. > Yes, that's fine because those device bindings do not require them. > Absence of "status" DT prop is treated as enabled by default. > But per current device tree spec, "status" in cpu node is mandatory. (spec uses "shall"). Missing it is a spec violation. Regards, Bin _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv