From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9235DC07E96 for ; Thu, 15 Jul 2021 11:45:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC1DD61260 for ; Thu, 15 Jul 2021 11:45:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC1DD61260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 91E518203D; Thu, 15 Jul 2021 13:45:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Dv/C6cuT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7513C82917; Thu, 15 Jul 2021 13:45:00 +0200 (CEST) Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 49E8482005 for ; Thu, 15 Jul 2021 13:44:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-yb1-xb33.google.com with SMTP id t186so8567443ybf.2 for ; Thu, 15 Jul 2021 04:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JWTKnaI8sGYuaskNDIPMSFaH2Yha8CfNKAg8sAKpGMM=; b=Dv/C6cuTtSDvvWjhmlZMT2KaN0Rd+Kl06LGzuHIdshHIMVk0JxWGap7Nsoh9ia8Mx8 XIB7MtoVCvzUZBUCcVgYe2s30/aBXooYmPePFmd7eaKJxJGgaLYLD1gWPNp2ySsQ6N4k MaNVh1GdHis80s50A3t/RfqdzKB5LGxjWzn76xDv+BXcax5f3Bt8IwBSx85LZvWKh7OR O2aA/lLrbtREZpc3OmebwmqWvIu9piIgb4JVFuAdxBoR60ZwdjGu7m86M2VP7Tkn0TbZ nwHHHOMPnEtaunqVsLelzXEMgOLaLnuMxn4ihRiIbTXE2JyT/gvQr2WhynQRZu9ILNfA XT2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JWTKnaI8sGYuaskNDIPMSFaH2Yha8CfNKAg8sAKpGMM=; b=r6tzXphD5++3J7H7W1EwzCOfSAOv7Pyiu+wsQgrDoX/0/2MdjjMxnouzv54+dCyQiV g2nJ6dCzsyD3NUzEuetW5GqFt9rpJkw8c4fHfbxLAzqvDS4vWvv1sW7Qeuag6uv5DyUs tWK/yUAUCv5tUKWDhVUIKKur513lmUg/gjF6JJ2v3WsrWIZWzrstP7KGRartK4/qRKFK h6dqi6rCOqWWmc8bacqeB2J2xTFnxIKtBmSmYws4UMpVwByuj6BxsYO+UCKukWxM741H QGEbTfj4ZOc3iyxgCUd+GQJzVCRDEwfOKG5XfUxMH4YOc6US789WlTHYBCDaHRjcThjh ulvg== X-Gm-Message-State: AOAM533XPxDsxC7NeQ25cE5Oq033ZxG/rD8KEwX2bfFYRhdI9HPQlB8J DnS/2b3fEoG89mYjzdpizdE4MzJZx1GLy/8Jcsk= X-Google-Smtp-Source: ABdhPJw/xO6Ey4L3gmr390xY5410G8pcfKcsoHQT/w2i0SNoISUNI/EX6wR332nB1xSStTHry60u+u7ZcvLM4prxy5E= X-Received: by 2002:a5b:504:: with SMTP id o4mr4866036ybp.332.1626349496015; Thu, 15 Jul 2021 04:44:56 -0700 (PDT) MIME-Version: 1.0 References: <20210627235111.485507-1-sjg@chromium.org> <20210627175102.v3.3.I967ea8c85e009f870c7aa944372d32c990f1b14a@changeid> In-Reply-To: <20210627175102.v3.3.I967ea8c85e009f870c7aa944372d32c990f1b14a@changeid> From: Bin Meng Date: Thu, 15 Jul 2021 19:44:44 +0800 Message-ID: Subject: Re: [PATCH v3 03/16] x86: Allow coreboot serial driver to guess the UART To: Simon Glass , Andy Shevchenko Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On Mon, Jun 28, 2021 at 7:51 AM Simon Glass wrote: > > At present this driver relies on coreboot to provide information about > the console UART. However if coreboot is not compiled with the UART > enabled, the information is left out. This configuration is quite > common, e.g. with shipping x86-based Chrome OS Chromebooks. > > Add a way to determine the UART settings in this case, using a > hard-coded list of PCI IDs. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/serial/serial_coreboot.c | 68 ++++++++++++++++++++++++++++---- > include/pci_ids.h | 1 + > 2 files changed, 61 insertions(+), 8 deletions(-) > Based on discussion of the last version, this patch should be dropped. I will see if I can drop it when applying. Regards, Bin