From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Thu, 24 Dec 2015 06:48:24 +0800 Subject: [U-Boot] [PATCH 02/10] x86: ivybridge: Add FSP support In-Reply-To: References: <1449831353-933-1-git-send-email-bmeng.cn@gmail.com> <1449831353-933-3-git-send-email-bmeng.cn@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On Thu, Dec 24, 2015 at 12:44 AM, Simon Glass wrote: > Hi Bin, > > On 20 December 2015 at 19:27, Bin Meng wrote: >> Hi Simon, >> >> On Sat, Dec 19, 2015 at 10:52 AM, Simon Glass wrote: >>> On 11 December 2015 at 03:55, Bin Meng wrote: >>>> IvyBridge FSP package is built with a base address at 0xfff80000, >>>> and does not use UPD data region. This adds basic FSP support. >>>> >>>> Signed-off-by: Bin Meng >>>> --- >>>> >>>> arch/x86/cpu/ivybridge/Kconfig | 8 ++++ >>>> arch/x86/cpu/ivybridge/Makefile | 4 ++ >>>> arch/x86/cpu/ivybridge/fsp_configs.c | 45 ++++++++++++++++++++++ >>>> arch/x86/cpu/ivybridge/ivybridge.c | 22 +++++++++++ >>>> .../include/asm/arch-ivybridge/fsp/fsp_configs.h | 40 +++++++++++++++++++ >>>> arch/x86/include/asm/arch-ivybridge/fsp/fsp_vpd.h | 12 ++++++ >>>> 6 files changed, 131 insertions(+) >>>> create mode 100644 arch/x86/cpu/ivybridge/fsp_configs.c >>>> create mode 100644 arch/x86/cpu/ivybridge/ivybridge.c >>>> create mode 100644 arch/x86/include/asm/arch-ivybridge/fsp/fsp_configs.h >>>> create mode 100644 arch/x86/include/asm/arch-ivybridge/fsp/fsp_vpd.h >>> >>> Acked-by: Simon Glass >>> Tested on link (ivybridge non-FSP) >>> Tested-by: Simon Glass >>> >>> One question: why do we need an Intel license on this code? >>> >> >> It was a copy and paste from other platform (queensbay and baytrail) >> files. Do you think we should change it to GPLv2+? > > Hmm - is it using this license because it was written by Intel, or > because you modified it from the FSP code that was written by Intel? > If so, then I suppose it is reasonable to use the Intel license. > The file was not written by Intel. Current U-Boot implementation is our own. I will change the license in v2. Regards, Bin