From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Thu, 7 Jan 2016 10:11:10 +0800
Subject: [U-Boot] [PATCH 1/3] pci: Add error values definitions from the
	kernel
In-Reply-To: <1452113598-32409-1-git-send-email-festevam@gmail.com>
References: <1452113598-32409-1-git-send-email-festevam@gmail.com>
Message-ID: <CAEUhbmWijmsSLrzBXRxrCZPKrZcDn6Bw5U6gYW=-xctLqg9-aQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Fabio,

On Thu, Jan 7, 2016 at 4:53 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Add PCI error values definitions from the kernel (include/linux/pci.h).
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  include/pci.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/include/pci.h b/include/pci.h
> index 2adca85..0ff3c6e 100644
> --- a/include/pci.h
> +++ b/include/pci.h
> @@ -451,6 +451,15 @@
>  #define PCI_EXT_CAP_ID_PMUX    0x1A    /* Protocol Multiplexing */
>  #define PCI_EXT_CAP_ID_PASID   0x1B    /* Process Address Space ID */
>
> +/* Error values that may be returned by PCI functions. */
> +#define PCIBIOS_SUCCESSFUL             0x00
> +#define PCIBIOS_FUNC_NOT_SUPPORTED     0x81
> +#define PCIBIOS_BAD_VENDOR_ID          0x83
> +#define PCIBIOS_DEVICE_NOT_FOUND       0x86
> +#define PCIBIOS_BAD_REGISTER_NUMBER    0x87
> +#define PCIBIOS_SET_FAILED             0x88
> +#define PCIBIOS_BUFFER_TOO_SMALL       0x89
> +
>  /* Include the ID list */
>
>  #include <pci_ids.h>
> --

Why should we introduce another set of error values just to fix this
specific PCIe issue? Isn't -EINVAL enough?

Regards,
Bin