From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Thu, 11 Oct 2018 17:50:09 +0800
Subject: [U-Boot] [PATCH 03/27] virtio: Add codes for virtual queue/ring
	management
In-Reply-To: <CAPnjgZ3+imTFqh_bwiHfTMmtxmgmCWDkD36o_FA-B-FxCu2vQA@mail.gmail.com>
References: <1537710145-1888-1-git-send-email-bmeng.cn@gmail.com>
 <1537710145-1888-4-git-send-email-bmeng.cn@gmail.com>
 <CAPnjgZ3+imTFqh_bwiHfTMmtxmgmCWDkD36o_FA-B-FxCu2vQA@mail.gmail.com>
Message-ID: <CAEUhbmWx=Dx0GrZTU6oY-O20SR7px=316+mHYYbcysspeFosDw@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On Thu, Sep 27, 2018 at 9:42 PM Simon Glass <sjg@chromium.org> wrote:
>
> On 23 September 2018 at 06:42, Bin Meng <bmeng.cn@gmail.com> wrote:
> > From: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> >
> > This adds support for managing virtual queue/ring, the channel
> > for high performance I/O between host and guest.
> >
> > Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> >
> >  drivers/virtio/Makefile      |   2 +-
> >  drivers/virtio/virtio_ring.c | 356 +++++++++++++++++++++++++++++++++++++++++++
> >  include/virtio_ring.h        | 320 ++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 677 insertions(+), 1 deletion(-)
> >  create mode 100644 drivers/virtio/virtio_ring.c
> >  create mode 100644 include/virtio_ring.h
>
> Seems like vring_create_virtqueue() should return an error code rather
> than a pointer?

I think NULL as a pointer can be a sign for the error.

>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Bin