From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B889CC07E9B for ; Tue, 6 Jul 2021 05:52:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29D696195D for ; Tue, 6 Jul 2021 05:52:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29D696195D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0e05-0002wY-3L for qemu-devel@archiver.kernel.org; Tue, 06 Jul 2021 01:52:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0dzH-0002H9-Su; Tue, 06 Jul 2021 01:51:15 -0400 Received: from mail-yb1-xb36.google.com ([2607:f8b0:4864:20::b36]:44867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0dzG-0001MC-2b; Tue, 06 Jul 2021 01:51:15 -0400 Received: by mail-yb1-xb36.google.com with SMTP id g19so32487978ybe.11; Mon, 05 Jul 2021 22:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rs7CgglGZGHMEXtjP9nb8ttTdEeYUOYnRKc6v6qD+IQ=; b=IPZRUpyF2zp3JD551D8m3wsktqh5las08p+H0Pi2rdFrnib0jGSsMCeYJPLkr9XYos 6kf84BWFbvSFr2XL7BWxJCo0GrXt7TW5NEPyf8tQF2WjgnpEbPxD/aBV1xfgTQMNI7Sn YKkU1iqp8zoXxw9TmpFV+6U9/6rzrdHE2MB2YBuXSbr4yxL3ypMfPyMeHS8llckmrVUy pm25erdc7Xsfh0vYVkplpu14KO5o0/F6Cz800sIfiyqmfEuxtCA9gfRmS09sIdljC7eI 5NghoZrD4DOGCBLZRCyoJorPRA5Lzg4Mb6veTZhIkpFIq5QXkVKkTMuxn/wiITHk065B g+8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rs7CgglGZGHMEXtjP9nb8ttTdEeYUOYnRKc6v6qD+IQ=; b=UiXJ2lat4ArdNPftdTKdIBSvSQ1qGnQcC/v3FcDbtgo7MtJ/ZkLKW657zCDx6gNkYA UQgudKyCQkICRyRTvGBxfckwuwETomaYAUYcHfgLMykbCnzGlAlLYWVDOjGKLnUitYco SLQ3gRKkx/kSW3UPfiVwgNi0eDk1qBjr/bVIeu9T+6Ks8ybfrURtTH8Na7QixkwYPCe4 m6CqOGIoKV4VSKfvy+WhXXzi25Ctf6Ji08k3MIWp/9zgakfjsJDYnKVPRs5eDAFF4ZnF XZCbfp5vKp0cCMRMWJrdfNo39qlym4a4tQSrK9fBCg8Nb0+MWeyd90I8vujkn2k6rGYL HkiA== X-Gm-Message-State: AOAM530v712GnsrbEPL0t9oJ8vzC3zcSY5VFyy9EAT/ZI2o3tfT1cBNC MuUFZ9enx2Y+IMg9KMU8sgMekgT4zZJ2Nt2P7BA= X-Google-Smtp-Source: ABdhPJyMbdfd3RSlCxTj5E4OBTbXjWUp5SZ/XXXa7LU/8R9JoP2S0oQOCismOCoNk4Gjshb3Ko+eucz4JC0P5f7ZR20= X-Received: by 2002:a25:6c04:: with SMTP id h4mr22839624ybc.122.1625550672686; Mon, 05 Jul 2021 22:51:12 -0700 (PDT) MIME-Version: 1.0 References: <20210706035015.122899-1-kito.cheng@sifive.com> In-Reply-To: <20210706035015.122899-1-kito.cheng@sifive.com> From: Bin Meng Date: Tue, 6 Jul 2021 13:51:01 +0800 Message-ID: Subject: Re: [PATCH v3] linux-user/elfload: Implement ELF_HWCAP for RISC-V To: Kito Cheng Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b36; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , frank.chang@sifive.com, Richard Henderson , "qemu-devel@nongnu.org Developers" , Palmer Dabbelt , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 6, 2021 at 11:50 AM Kito Cheng wrote: > > Set I, M, A, F, D and C bit for hwcap if misa is set. > > V3 Changes: > - Simplify logic of getting hwcap. > > V2 Changes: > - Only set imafdc bits, sync with upstream linux kernel. These changelogs should not be in the commit message, but should be put below --- > > Signed-off-by: Kito Cheng > --- > linux-user/elfload.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/linux-user/elfload.c b/linux-user/elfload.c > index 598ab8aa13..42ef2a1148 100644 > --- a/linux-user/elfload.c > +++ b/linux-user/elfload.c > @@ -1434,6 +1434,19 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs, > #define ELF_CLASS ELFCLASS64 > #endif > > +#define ELF_HWCAP get_elf_hwcap() > + > +static uint32_t get_elf_hwcap(void) > +{ > +#define MISA_BIT(EXT) (1 << (EXT - 'A')) > + RISCVCPU *cpu = RISCV_CPU(thread_cpu); > + uint32_t mask = MISA_BIT('I') | MISA_BIT('M') | MISA_BIT('A') > + | MISA_BIT('F') | MISA_BIT('D') | MISA_BIT('C'); > + > + return cpu->env.misa & mask; > +#undef MISA_BIT > +} > + > static inline void init_thread(struct target_pt_regs *regs, > struct image_info *infop) > { Regards, Bin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m0dzJ-0002HY-CW for mharc-qemu-riscv@gnu.org; Tue, 06 Jul 2021 01:51:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0dzH-0002H9-Su; Tue, 06 Jul 2021 01:51:15 -0400 Received: from mail-yb1-xb36.google.com ([2607:f8b0:4864:20::b36]:44867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0dzG-0001MC-2b; Tue, 06 Jul 2021 01:51:15 -0400 Received: by mail-yb1-xb36.google.com with SMTP id g19so32487978ybe.11; Mon, 05 Jul 2021 22:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rs7CgglGZGHMEXtjP9nb8ttTdEeYUOYnRKc6v6qD+IQ=; b=IPZRUpyF2zp3JD551D8m3wsktqh5las08p+H0Pi2rdFrnib0jGSsMCeYJPLkr9XYos 6kf84BWFbvSFr2XL7BWxJCo0GrXt7TW5NEPyf8tQF2WjgnpEbPxD/aBV1xfgTQMNI7Sn YKkU1iqp8zoXxw9TmpFV+6U9/6rzrdHE2MB2YBuXSbr4yxL3ypMfPyMeHS8llckmrVUy pm25erdc7Xsfh0vYVkplpu14KO5o0/F6Cz800sIfiyqmfEuxtCA9gfRmS09sIdljC7eI 5NghoZrD4DOGCBLZRCyoJorPRA5Lzg4Mb6veTZhIkpFIq5QXkVKkTMuxn/wiITHk065B g+8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rs7CgglGZGHMEXtjP9nb8ttTdEeYUOYnRKc6v6qD+IQ=; b=UiXJ2lat4ArdNPftdTKdIBSvSQ1qGnQcC/v3FcDbtgo7MtJ/ZkLKW657zCDx6gNkYA UQgudKyCQkICRyRTvGBxfckwuwETomaYAUYcHfgLMykbCnzGlAlLYWVDOjGKLnUitYco SLQ3gRKkx/kSW3UPfiVwgNi0eDk1qBjr/bVIeu9T+6Ks8ybfrURtTH8Na7QixkwYPCe4 m6CqOGIoKV4VSKfvy+WhXXzi25Ctf6Ji08k3MIWp/9zgakfjsJDYnKVPRs5eDAFF4ZnF XZCbfp5vKp0cCMRMWJrdfNo39qlym4a4tQSrK9fBCg8Nb0+MWeyd90I8vujkn2k6rGYL HkiA== X-Gm-Message-State: AOAM530v712GnsrbEPL0t9oJ8vzC3zcSY5VFyy9EAT/ZI2o3tfT1cBNC MuUFZ9enx2Y+IMg9KMU8sgMekgT4zZJ2Nt2P7BA= X-Google-Smtp-Source: ABdhPJyMbdfd3RSlCxTj5E4OBTbXjWUp5SZ/XXXa7LU/8R9JoP2S0oQOCismOCoNk4Gjshb3Ko+eucz4JC0P5f7ZR20= X-Received: by 2002:a25:6c04:: with SMTP id h4mr22839624ybc.122.1625550672686; Mon, 05 Jul 2021 22:51:12 -0700 (PDT) MIME-Version: 1.0 References: <20210706035015.122899-1-kito.cheng@sifive.com> In-Reply-To: <20210706035015.122899-1-kito.cheng@sifive.com> From: Bin Meng Date: Tue, 6 Jul 2021 13:51:01 +0800 Message-ID: Subject: Re: [PATCH v3] linux-user/elfload: Implement ELF_HWCAP for RISC-V To: Kito Cheng Cc: Alistair Francis , Palmer Dabbelt , frank.chang@sifive.com, "qemu-devel@nongnu.org Developers" , "open list:RISC-V" , Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b36; envelope-from=bmeng.cn@gmail.com; helo=mail-yb1-xb36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 05:51:16 -0000 On Tue, Jul 6, 2021 at 11:50 AM Kito Cheng wrote: > > Set I, M, A, F, D and C bit for hwcap if misa is set. > > V3 Changes: > - Simplify logic of getting hwcap. > > V2 Changes: > - Only set imafdc bits, sync with upstream linux kernel. These changelogs should not be in the commit message, but should be put below --- > > Signed-off-by: Kito Cheng > --- > linux-user/elfload.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/linux-user/elfload.c b/linux-user/elfload.c > index 598ab8aa13..42ef2a1148 100644 > --- a/linux-user/elfload.c > +++ b/linux-user/elfload.c > @@ -1434,6 +1434,19 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs, > #define ELF_CLASS ELFCLASS64 > #endif > > +#define ELF_HWCAP get_elf_hwcap() > + > +static uint32_t get_elf_hwcap(void) > +{ > +#define MISA_BIT(EXT) (1 << (EXT - 'A')) > + RISCVCPU *cpu = RISCV_CPU(thread_cpu); > + uint32_t mask = MISA_BIT('I') | MISA_BIT('M') | MISA_BIT('A') > + | MISA_BIT('F') | MISA_BIT('D') | MISA_BIT('C'); > + > + return cpu->env.misa & mask; > +#undef MISA_BIT > +} > + > static inline void init_thread(struct target_pt_regs *regs, > struct image_info *infop) > { Regards, Bin