All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [PATCH 1/2] spi: ich: Limit slave->max_read_size
Date: Thu, 29 Jul 2021 20:04:29 +0800	[thread overview]
Message-ID: <CAEUhbmX0KTLU6fbJrPCatjOB6YRjpZiV_NgqYGQwK1vAmBVN0A@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ0tGKjYaXeh81VC5Xxubafk4iBjQeTKv0KZN6R-jqwn=Q@mail.gmail.com>

On Thu, Jul 29, 2021 at 9:32 AM Simon Glass <sjg@chromium.org> wrote:
>
> On Wed, 28 Jul 2021 at 04:29, Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > Since commit 43c145b8b3ee ("spi: ich: Correct max-size bug in ich_spi_adjust_size()")
> > (in v2020.04-rc1), SPI flash read no longer works with ICH SPI controller
> > in software sequencer mode.
> >
> > ICH controller can only transfer a small number of bytes at once.
> > Before commit 43c145b8b3ee, the logic happens to make sure data.nbytes
> > is limited to slave->max_write_size but after commit 43c145b8b3ee
> > data.nbytes is no longer limited because slave->max_read_size is not
> > initialized with a valid number.
> >
> > Fixes: 43c145b8b3ee ("spi: ich: Correct max-size bug in ich_spi_adjust_size()")
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> >
> >  drivers/spi/ich.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

      reply	other threads:[~2021-07-29 12:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 10:28 [PATCH 1/2] spi: ich: Limit slave->max_read_size Bin Meng
2021-07-28 10:28 ` [PATCH 2/2] x86: crownbay: Disable CONFIG_SPI_FLASH_SMART_HWCAPS Bin Meng
2021-07-29  1:45   ` Simon Glass
2021-07-29 12:04     ` Bin Meng
2021-07-29  1:32 ` [PATCH 1/2] spi: ich: Limit slave->max_read_size Simon Glass
2021-07-29 12:04   ` Bin Meng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmX0KTLU6fbJrPCatjOB6YRjpZiV_NgqYGQwK1vAmBVN0A@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=jagan@amarulasolutions.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.