From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Thu, 23 Apr 2020 17:38:40 +0800 Subject: [PATCH v7 7/9] acpi: Put table-setup code in its own function In-Reply-To: <20200419143624.v7.7.I34e9fcd28119cc2fcb87ad8679efb582a4c611df@changeid> References: <20200419203657.163143-1-sjg@chromium.org> <20200419143624.v7.7.I34e9fcd28119cc2fcb87ad8679efb582a4c611df@changeid> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, Wolfgang, On Mon, Apr 20, 2020 at 4:37 AM Simon Glass wrote: > > We always write three basic tables to ACPI at the start. Move this into > its own function, along with acpi_fill_header(), so we can write a test > for this code. > > Signed-off-by: Simon Glass I see Wolfgang gave a RB tag to the v5 patch, so I am going to add that tag here since no changes between v5 and v7 Reviewed-by: Wolfgang Wallner But I wonder why this new series is tagged as v7. Do I miss v6? > --- > > Changes in v7: None > Changes in v5: None > Changes in v4: > - Put back cast on table_compute_checksum() > > Changes in v3: > - Fix 'XDST' typo > - Move acpi_align_large() out of dm_test_acpi_setup_base_tables() > - Beef up the comment explaining how the unaligned address is used > > Changes in v2: None > > arch/x86/lib/acpi_table.c | 72 +----------------------------------- > include/acpi/acpi_table.h | 10 +++++ > lib/acpi/acpi_table.c | 77 +++++++++++++++++++++++++++++++++++++++ > test/dm/acpi.c | 58 ++++++++++++++++++++++++++++- > 4 files changed, 144 insertions(+), 73 deletions(-) > Regards, Bin