All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] x86: acpi: Adopt new version of iASL compiler
Date: Fri, 25 May 2018 11:58:02 +0800	[thread overview]
Message-ID: <CAEUhbmX98+EdXZew1Mf-PxtXi2SxmLBwVoW6y04bugLttrGLdA@mail.gmail.com> (raw)
In-Reply-To: <40e3877de353004da151e6443b559106e2725871.camel@linux.intel.com>

On Wed, May 23, 2018 at 6:29 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Wed, 2018-05-23 at 18:22 +0800, Bin Meng wrote:
>> Hi Andy,
>>
>> On Wed, May 23, 2018 at 5:38 PM, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>> > The commit
>> >
>> >   f9a88a4c1cd0 ("iASL: Enhance the -tc option (create AML hex file
>> > in C)")
>> >
>> > in ACPICA project changed a template of the a of variable that is
>> > used
>>
>> a template of the a of variable? Cannot understand this.
>
> "a template of the variable"
>

Fixed this in the commit message

>>
>> > in the generated C-file. Now, instead of hard coded "AmlCode" the
>> > "%s_aml_code" is in use, where the prefix is a lowered case base
>> > name of
>> > the output file. In our case it will be "dsdt" producing a name as
>> > "dsdt_aml_code".
>> >
>> > The quick solution is to call sed which replaces new name by the old
>> > one
>> > to keep compatibility with old version of iASL.
>> >
>> > The long term solution would be to modify code to use the new name
>> > because it more scalable.
>>
>> it *is* more scalable.
>
> Yes, thanks.
>

and here, and

applied to u-boot-x86, thanks!

      parent reply	other threads:[~2018-05-25  3:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23  9:38 [U-Boot] [PATCH v1] x86: acpi: Adopt new version of iASL compiler Andy Shevchenko
2018-05-23 10:22 ` Bin Meng
2018-05-23 10:29   ` Andy Shevchenko
2018-05-23 14:30     ` Moore, Robert
2018-05-25  3:58     ` Bin Meng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmX98+EdXZew1Mf-PxtXi2SxmLBwVoW6y04bugLttrGLdA@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.