From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E77AC433EF for ; Tue, 2 Nov 2021 12:46:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0DD960EB8 for ; Tue, 2 Nov 2021 12:46:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E0DD960EB8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ABF8881BC8; Tue, 2 Nov 2021 13:46:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jbIA0NzS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D4770815A8; Tue, 2 Nov 2021 13:46:12 +0100 (CET) Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 512BF81BC8 for ; Tue, 2 Nov 2021 13:46:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-yb1-xb2c.google.com with SMTP id 131so41254074ybc.7 for ; Tue, 02 Nov 2021 05:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BsA8K9m3gRiqPOPfnBsaSI+vC2C1DEr6ImWAK9xXcTk=; b=jbIA0NzSC+RnpT6l7Delo4Qpc8zq9IMGR0m+/M1hhR41AhXdbutU7XpNqy41T7jUxW PQ+Ng30Gn52dvK+MJIqJGx+AwGKxP5+EHN8628G22XGa3WQDaJWt5Kpjsl6ojNi+m2Ks vIYWRut4i1EFn0iFAszpN1Gz636+VYVNm5bQ2ZqdF2T+lhxNnqd9sMrn8LkIAX3ARmci aaB+leFSeEwInUOm1p3e7LcBRIxrfYFkLyePwPFKyIKihaK7lVZpWqJPoPpoOFHBjkac OcdY98U+lkv6E6pd8ekmt0zzOfbELdNpC7vbddt4juVYZOaa4lIVyoWL57aedACZd4Wp z8ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BsA8K9m3gRiqPOPfnBsaSI+vC2C1DEr6ImWAK9xXcTk=; b=ssbVfTaplEloRm1mdNs+S3dN1PeoB+q8dvCaH7T8X9xwmSNtXw1ID3a1m3/BiKCn1O 3r1X1ZcJ61L3mj5Vda1E/GgiiYHv3Jy/R/Ft1mFKEhByL8MYuQuXFZxfOO6c1biCxqCc OaYRmblqBXbFD91B6Qg+JQcHtRrxgLPRO0Lq37ZUOH4iQDALdR6N5ZlakyZS1eJPDQ1K XbQhoFGyTqeH4LM/HkiydX1TSCbJ4vU+yjdf06aQ8N8QrsNfzE2jtOt/dZEAtEz10lFZ X9Hb87DweWY55bhq8QS1HuB3KaGdadbr0R2ZSyRtytY5p3I1n/77nqsc3v50c+jJZLRD gBQA== X-Gm-Message-State: AOAM530yodl2bo4GMg3QVZlRWXPFFPhsMJ7aJnvO8b5BsJ2MJC1P2VHJ 5W2ayeg6ct8ltN4yHFSSdzcumLnNJVquQ5nqbZw= X-Google-Smtp-Source: ABdhPJy2HTL3agqaanVGVy2m5zvuSlzW2lxwx45KXnLi33nDK2Fcg5DCNAbpMK4rWsvsvoSIgvoSPFJdaJT0YSFTlbU= X-Received: by 2002:a25:cc07:: with SMTP id l7mr28007756ybf.313.1635857168057; Tue, 02 Nov 2021 05:46:08 -0700 (PDT) MIME-Version: 1.0 References: <20211022085648.134655-1-padmarao.begari@microchip.com> <20211022085648.134655-5-padmarao.begari@microchip.com> In-Reply-To: From: Bin Meng Date: Tue, 2 Nov 2021 20:45:57 +0800 Message-ID: Subject: Re: [PATCH v1 4/5] net: macb: Compatible as per device tree To: Padmarao Begari Cc: Padmarao Begari , U-Boot Mailing List , Rick Chen , Anup Patel , Atish Patra , Heiko Schocher , cyril.jean@microchip.com, Lewis Hanly , Conor Dooley , Daire McNamara , ivan.griffin@microchip.com, valentina.fernandezalanis@microchip.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Padmarao, On Tue, Nov 2, 2021 at 7:03 PM Padmarao Begari wrote: > > Hi Bin, > > On Mon, Nov 1, 2021 at 2:15 PM Bin Meng wrote: >> >> On Fri, Oct 22, 2021 at 4:58 PM Padmarao Begari >> wrote: >> > >> > Update compatible as per Microchip PolarFire SoC ethernet >> > device node. >> > >> > Signed-off-by: Padmarao Begari >> > --- >> > drivers/net/macb.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/net/macb.c b/drivers/net/macb.c >> > index 8c6461e717..1b867bd5c2 100644 >> > --- a/drivers/net/macb.c >> > +++ b/drivers/net/macb.c >> > @@ -1502,7 +1502,7 @@ static const struct udevice_id macb_eth_ids[] = { >> > { .compatible = "cdns,zynq-gem" }, >> > { .compatible = "sifive,fu540-c000-gem", >> > .data = (ulong)&sifive_config }, >> > - { .compatible = "microchip,mpfs-mss-gem", >> > + { .compatible = "microchip,mpfs-gem", >> >> Could you please provide the upstream Linux kernel binding reference? >> I can't find such string in the Linux kernel. >> > > We are not upstreamed Linux bindings yet, soon we will do. > > The compatible "cdns,macb" is used in Linux for 32-bit and 64-bit DMA transfer and U-Boot for 32-bit DMA transfer. > We added this string to support 64-bit DMA transfer of the GEM. > I suggest we upstream the new compatible string binding first, then update U-Boot. Otherwise U-Boot might be updated again if the compatible string is changed during the upstream review process. Regards, Bin