From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B101C4338F for ; Mon, 2 Aug 2021 03:15:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0F0061050 for ; Mon, 2 Aug 2021 03:15:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E0F0061050 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E74D783327; Mon, 2 Aug 2021 05:14:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="t9JiZfw4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 738B68332A; Mon, 2 Aug 2021 05:14:57 +0200 (CEST) Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4D64D83311 for ; Mon, 2 Aug 2021 05:14:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-yb1-xb35.google.com with SMTP id a93so8186175ybi.1 for ; Sun, 01 Aug 2021 20:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XVl3l0Lh4KGG6i8kwpJjdFeEQM5Nf+cFUNnFKG/cPWE=; b=t9JiZfw4/4BjdMFqOYqtvSI7g1/sB7iwiMhZtXE2x3HjVpO3YSLZyKUXvKVoLdvPq9 88YX1SODinDAm/WNPxGNzxkZcbmExtrzrah8XjYzZtoJU5rwTQ3+H/AKUauXtlnU7KVf NUkKagCenJ6IEDM+VYtBobihXx2PB/uYtq1GbSiMEgBCzRwxpk5AdWorKyOea+9ILsMK gttOj5QZd6U3pvMvLLZl9VxRgwdyaIVJY54ivofeTDWNqDZCheDf6ca1/iaTSLE2wC2X EF0PSrFpgIPNUelJAciKcfCiItp0dwk+CKov6kSEGpx6tZCW2Q+RVUJ8f5vulC4YzlMz kOTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XVl3l0Lh4KGG6i8kwpJjdFeEQM5Nf+cFUNnFKG/cPWE=; b=QovW+qWA1HydZhjNPbvrximDtsGufKwaEK1TUJNc2LkvJyc2s249IZgPDOExWaPIAi wsjQ7tPAd/9koGNEmPqqdsDZ/ulFThNQikVLrXuCt0LjL/ZVbt30lOqQKMzbSY9TZx0F T3ws3qVpOvww+nYRzOfPr1OsvOS4ch3vWr2dv8URsMqXTNVJnR65aekArCCwdKhqXMYk qQO0HjpqAcjEEyzWe7GpmOTGVBo4XBzAJmOrmNYk4SIepXV4PJp6CYCy6LI7rHvTrXJO hGbHvJBfPx5DcQtyz3btSDfCeGpCu+oQDKgKKvykclRimXhAwsKDzPYPDuYMisJdUIAT DPZg== X-Gm-Message-State: AOAM531GSQPIaGpbKKLg8CjqJSYDh0VxLO9nIJbeFy1Hxo3VATeXkf4l JsXdU05auPE5nc2rxd0g+aqEDAfKxgsTJHcMSIk= X-Google-Smtp-Source: ABdhPJyP2xx9FqorxzzQoQkhLL6qiOZVcV4KC/plX0Zzm4qaa7s2D1qmijIGzqo/t54AU2Frmp4C4hFDvAmqrA5OIio= X-Received: by 2002:a25:be09:: with SMTP id h9mr19822216ybk.239.1627874093129; Sun, 01 Aug 2021 20:14:53 -0700 (PDT) MIME-Version: 1.0 References: <20210731131652.19206-1-bmeng.cn@gmail.com> In-Reply-To: From: Bin Meng Date: Mon, 2 Aug 2021 11:14:42 +0800 Message-ID: Subject: Re: [PATCH 1/2] x86: queensbay: Optimize disable_igd() a little To: Simon Glass Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > Hi Bin, > > On Sat, 31 Jul 2021 at 07:17, Bin Meng wrote: > > > > Initialize igd and sdvo to NULL so that we don't need to test the > > return value of dm_pci_bus_find_bdf() later. > > > > Signed-off-by: Bin Meng > > --- > > > > arch/x86/cpu/queensbay/tnc.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/arch/x86/cpu/queensbay/tnc.c b/arch/x86/cpu/queensbay/tnc.c > > index 782ed863fe..e38c0198e4 100644 > > --- a/arch/x86/cpu/queensbay/tnc.c > > +++ b/arch/x86/cpu/queensbay/tnc.c > > @@ -18,18 +18,15 @@ > > > > static int __maybe_unused disable_igd(void) > > { > > - struct udevice *igd, *sdvo; > > + struct udevice *igd = NULL; > > + struct udevice *sdvo = NULL; > > int ret; > > > > ret = dm_pci_bus_find_bdf(TNC_IGD, &igd); > > - if (ret) > > - return ret; > > if (!igd) > > return 0; > > This is backwards. If ret returns 0 then we know igd is non-NULL. So > check the return value. That is what it is for. You can drop the check > of igd. Same below. > Ah, yes. I remembered why the original codes were written like this. Actually the codes tried to be compatible that if the device is already disabled it should not return error. I will reword the commit message and add some comments here. Regards, Bin