All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: storage: Fix overwritten in usb_stor_set_max_xfer_blk()
Date: Sun, 1 Oct 2017 21:18:42 +0800	[thread overview]
Message-ID: <CAEUhbmXHZ6UMVoE=1f6i66Pegjf4UQ3uqizM6QvBUCWytFaxzQ@mail.gmail.com> (raw)
In-Reply-To: <2ac309dd-6ed9-e188-a761-d2e5b3555927@denx.de>

Hi Marek,

On Fri, Sep 29, 2017 at 5:36 PM, Marek Vasut <marex@denx.de> wrote:
> On 09/29/2017 11:26 AM, Bin Meng wrote:
>> Hi Marek,
>>
>> On Fri, Sep 29, 2017 at 10:30 AM, Marek Vasut <marex@denx.de> wrote:
>>> On 09/29/2017 01:36 AM, Bin Meng wrote:
>>>> Hi Marek,
>>>>
>>>> On Thu, Sep 28, 2017 at 11:24 PM, Marek Vasut <marex@denx.de> wrote:
>>>>> On 09/28/2017 06:50 AM, Bin Meng wrote:
>>>>>> The stored 'blk' value is overwritten to 'size / 512' before it can
>>>>>> be used in usb_stor_set_max_xfer_blk(). This is not what we want.
>>>>>> In fact, when 'size' exceeds the upper limit (USHRT_MAX * 512), we
>>>>>> should simply assign 'size' to the upper limit.
>>>>>>
>>>>>> Reported-by: Coverity (CID: 167250)
>>>>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>>>>
>>>>> Still failing
>>>>> https://travis-ci.org/marex/u-boot-usb/builds/280835848
>>>>>
>>>>
>>>> This fixes the Coverity issue, not the 'make tests' issue. Please hold
>>>> on apply the xHCI patchset and when the fix is ready I will send v2.
>>>
>>> Can't you send me fix on top of current set ? If not, OK, tell me what
>>> to drop and what to pick.
>>>
>>
>> OK, will do.
>
> Thanks!
>

I just sent additional patches
(http://patchwork.ozlabs.org/project/uboot/list/?series=5892) to fix
the 'make tests' issues.

Please do the following on the u-boot-usb/master branch:

1). Drop http://git.denx.de/?p=u-boot/u-boot-usb.git;a=commit;h=198db64035a589ef19920b2cec58419b4b338ce7
2). Drop http://git.denx.de/?p=u-boot/u-boot-usb.git;a=commit;h=9a462a3af216d77fee689f119419506218531f77
3). Apply http://patchwork.ozlabs.org/project/uboot/list/?series=5892
on top of u-boot-usb/master

Then everything should be fine.

Regards,
Bin

  reply	other threads:[~2017-10-01 13:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28  4:50 [U-Boot] [PATCH] usb: storage: Fix overwritten in usb_stor_set_max_xfer_blk() Bin Meng
2017-09-28 15:24 ` Marek Vasut
2017-09-28 23:36   ` Bin Meng
2017-09-29  2:30     ` Marek Vasut
2017-09-29  9:26       ` Bin Meng
2017-09-29  9:36         ` Marek Vasut
2017-10-01 13:18           ` Bin Meng [this message]
2017-10-01 18:41             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmXHZ6UMVoE=1f6i66Pegjf4UQ3uqizM6QvBUCWytFaxzQ@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.