All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: David Gibson <david@gibson.dropbear.id.au>,
	Greg Kurz <groug@kaod.org>,  Jason Wang <jasowang@redhat.com>
Cc: qemu-ppc <qemu-ppc@nongnu.org>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC
Date: Mon, 22 Mar 2021 09:29:12 +0800	[thread overview]
Message-ID: <CAEUhbmXPvyLT-ZTr+aSECLvmosyVnYASNZa=YAKcU0v4a7-Aaw@mail.gmail.com> (raw)
In-Reply-To: <20210316081505.72898-1-bmeng.cn@gmail.com>

On Tue, Mar 16, 2021 at 4:15 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU",
> min_frame_len should excluce CRC, so it should be 60 instead of 64.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  hw/net/fsl_etsec/rings.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Ping?


  reply	other threads:[~2021-03-22  1:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16  8:15 [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC Bin Meng
2021-03-22  1:29 ` Bin Meng [this message]
2021-03-22  3:22   ` David Gibson
2021-03-22  3:22 ` David Gibson
2021-03-22  4:33   ` Bin Meng
2021-03-22  5:17     ` David Gibson
2021-03-22  5:48       ` Bin Meng
2021-03-23  0:08         ` David Gibson
2021-03-23  0:08 ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmXPvyLT-ZTr+aSECLvmosyVnYASNZa=YAKcU0v4a7-Aaw@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.