All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] fs: cbfs: remove wrong header validation
Date: Mon, 31 Dec 2018 09:44:33 +0800	[thread overview]
Message-ID: <CAEUhbmXRp_jn6q-1jbEwpELQyFE-HB4pLe2jgtqS-21dh+ND5g@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ3WS=sKO8gh6oPDvqptmCWEhQVTBf4_6KFt+afT_kQ2uw@mail.gmail.com>

On Sat, Dec 29, 2018 at 9:40 PM Simon Glass <sjg@chromium.org> wrote:
>
> On Sat, 22 Dec 2018 at 02:50, Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > From: Christian Gmeiner <christian.gmeiner@gmail.com>
> >
> > cbfs_fileheader.len indicates the content size of the file in the
> > cbfs, and it has nothing to do with cbfs_fileheader.offset which
> > is the starting address of the file in the cbfs.
> >
> > Remove such check in file_cbfs_next_file(). Before this change
> > 'cbfsinit' failed with 'Bad CBFS file'. After this change all cbfs
> > commands are working as expected.
> >
> > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > [bmeng: keep the necessary header sanity check]
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > ---
> >
> >  fs/cbfs/cbfs.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!

      reply	other threads:[~2018-12-31  1:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-22  9:55 [U-Boot] [PATCH 1/4] fs: cbfs: remove wrong header validation Bin Meng
2018-12-22  9:55 ` [U-Boot] [PATCH 2/4] fs: cbfs: Fix out of bound access during CBFS walking through Bin Meng
2018-12-29 13:39   ` Simon Glass
2018-12-31  1:44     ` Bin Meng
2018-12-22  9:55 ` [U-Boot] [PATCH 3/4] fs: cbfs: Make all CBFS_TYPE_xxx macros consistent Bin Meng
2018-12-29 13:39   ` Simon Glass
2018-12-31  1:45     ` Bin Meng
2018-12-22  9:55 ` [U-Boot] [PATCH 4/4] fs: cbfs: Add missing standard CBFS component types Bin Meng
2018-12-29 13:39   ` Simon Glass
2018-12-31  1:45     ` Bin Meng
2018-12-29 13:39 ` [U-Boot] [PATCH 1/4] fs: cbfs: remove wrong header validation Simon Glass
2018-12-31  1:44   ` Bin Meng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmXRp_jn6q-1jbEwpELQyFE-HB4pLe2jgtqS-21dh+ND5g@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.