From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Thu, 8 Apr 2021 10:59:42 +0800
Subject: [PATCH 15/17] x86: Check ROM exists before building vboot
In-Reply-To: <20210407163159.15.Ic5602c03301b09f3ae3fc1b3fb5809ee130866e8@changeid>
References: <20210407043228.2268429-1-sjg@chromium.org>
 <20210407163159.15.Ic5602c03301b09f3ae3fc1b3fb5809ee130866e8@changeid>
Message-ID: <CAEUhbmXWEp0nYywGNN=a=-01U=Bri6sS3A-buY4gQH8FR0Ui1A@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On Wed, Apr 7, 2021 at 12:33 PM Simon Glass <sjg@chromium.org> wrote:
>
> All the x86 devicetree files are built at once, whichever board is
> actually being built. If coreboot is the target build, CONFIG_ROM_SIZE
> is not defined and samus cannot build Chromium OS verified boot. Add
> this condition to avoid errors about CONFIG_ROM_SIZE being missing.

The commit title should use "x86: chromebook" as the tags, since it's
not x86 generic thing.

>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  arch/x86/dts/chromebook_coral.dts | 2 +-
>  arch/x86/dts/chromebook_samus.dts | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>

Otherwise,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin