From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Wed, 20 Apr 2016 22:42:53 +0800 Subject: [U-Boot] [PATCH] x86: qemu: Drop our own ACPI implementation In-Reply-To: <571794DC.50901@denx.de> References: <1460533969-1189-1-git-send-email-bmeng.cn@gmail.com> <571794DC.50901@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, On Wed, Apr 20, 2016 at 10:40 PM, Stefan Roese wrote: > Hi Bin, > > > On 20.04.2016 15:45, Bin Meng wrote: >> >> On Wed, Apr 20, 2016 at 9:13 PM, Simon Glass wrote: >>> >>> Hi Bin, >>> >>> On 13 April 2016 at 01:52, Bin Meng wrote: >>>> >>>> Our own ACPI implementation (when CONFIG_QEMU_ACPI_TABLE is not set) >>>> does not build anymore after x86 has been fully converted to DM PCI. >>>> Instead of trying to fix the build errors, given we now have the ACPI >>>> support via QEMU's fw_cfg interface, which is a more reliable way to >>>> generate correct ACPI tables then by ourselves, hence drop our own >>>> ACPI implementation. >>>> >>>> Signed-off-by: Bin Meng >>>> >>>> --- >>>> >>>> arch/x86/cpu/qemu/Makefile | 3 - >>>> arch/x86/cpu/qemu/acpi.c | 176 -------------- >>>> arch/x86/cpu/qemu/acpi/cpu-hotplug.asl | 80 ------- >>>> arch/x86/cpu/qemu/acpi/dbug.asl | 25 -- >>>> arch/x86/cpu/qemu/acpi/hpet.asl | 31 --- >>>> arch/x86/cpu/qemu/acpi/isa.asl | 102 -------- >>>> arch/x86/cpu/qemu/acpi/pci-crs.asl | 61 ----- >>>> arch/x86/cpu/qemu/dsdt.asl | 412 --------------------------------- >>>> 8 files changed, 890 deletions(-) >>>> delete mode 100644 arch/x86/cpu/qemu/acpi.c >>>> delete mode 100644 arch/x86/cpu/qemu/acpi/cpu-hotplug.asl >>>> delete mode 100644 arch/x86/cpu/qemu/acpi/dbug.asl >>>> delete mode 100644 arch/x86/cpu/qemu/acpi/hpet.asl >>>> delete mode 100644 arch/x86/cpu/qemu/acpi/isa.asl >>>> delete mode 100644 arch/x86/cpu/qemu/acpi/pci-crs.asl >>>> delete mode 100644 arch/x86/cpu/qemu/dsdt.asl >>> >>> >>> Reviewed-by: Simon Glass >>> >>> My only concern is that this was supposed to lead to ACPI support for >>> real >>> hardware. If you drop this, does it make it harder? >> >> >> No, the infrastructure is still there. Only the QEMU ASL (manual) part >> was removed. I am going to add ACPI support to BayTrail soon >> (hopefully). > > > Interesting. This is also on my to-do list. We should definitely > coordinate our efforts here. So please keep me updated once you > really start here. I'll do the same. :) > Definitely. I plan to ping you before I really start to write anything as I remember you did mention ACPI before. I don't want to see any duplicated effort :-) Regards, Bin