All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Alexander Bulekov" <alxndr@bu.edu>,
	"Andrew Jeffery" <andrew@aj.id.au>, "Ani Sinha" <ani@anisinha.ca>,
	"Bandan Das" <bsd@redhat.com>, "Beraldo Leal" <bleal@redhat.com>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
	"Coiby Xu" <Coiby.Xu@gmail.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Darren Kenny" <darren.kenny@oracle.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Fam Zheng" <fam@euphon.net>, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Greg Kurz" <groug@kaod.org>, "Hanna Reitz" <hreitz@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Joel Stanley" <joel@jms.id.au>, "John Snow" <jsnow@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Konstantin Kostiuk" <kkostiuk@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Qiuhao Li" <Qiuhao.Li@outlook.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	qemu-arm@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v4 00/54] tests/qtest: Enable running qtest on Windows
Date: Mon, 3 Oct 2022 18:08:09 +0800	[thread overview]
Message-ID: <CAEUhbmXXUcW0jb4VXBHeemjZoHD2fcnzMmfo=rX55BREN2KXHA@mail.gmail.com> (raw)
In-Reply-To: <CAJ+F1CJ3cTdNwZEQ5i+05mgYXXngyRAF6MoX6JFadsp9tKEgmg@mail.gmail.com>

Hi Marc-André,

On Mon, Oct 3, 2022 at 5:26 PM Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
> Hi Bin
>
> On Tue, Sep 27, 2022 at 3:18 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>>
>> In preparation to adding virtio-9p support on Windows, this series
>> enables running qtest on Windows, so that we can run the virtio-9p
>> tests on Windows to make sure it does not break accidently.
>>
>> Changes in v4:
>> - Do not use g_autofree and g_steal_pointer
>> - Update the error reporting by using the GError "error" argument
>>   of g_dir_make_tmp()
>> - Remove the const from tmpfs declaration
>> - Replace the whole block with a g_assert_no_error()
>> - Replace the error reporting with g_assert_no_error()
>> - Update error reporting
>> - Move the new text section after the "QTest" section instead
>> - Use plural in both cases: "on POSIX hosts as well as Windows hosts"
>> - Use "The following list shows some best practices"
>> - Fix typo of delimiter
>> - New patch: "tests/qtest: boot-serial-test: Close the serial file before starting QEMU"
>> - Drop patch: "chardev/char-file: Add FILE_SHARE_WRITE when openning the file for win32"
>>
>
> Could you post a v5 rebased on the current master? thanks
>

Sure, will do.

> (I think most of the remaining patches are simple enough that I could take them in a misc PR if they are not picked by subsystem maintainers)

Thank you.

Regards,
Bin


      reply	other threads:[~2022-10-03 10:17 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 11:05 [PATCH v4 00/54] tests/qtest: Enable running qtest on Windows Bin Meng
2022-09-27 11:05 ` [PATCH v4 01/54] tests/qtest: i440fx-test: Rewrite create_blob_file() to be portable Bin Meng
2022-09-27 11:05 ` [PATCH v4 02/54] semihosting/arm-compat-semi: Avoid using hardcoded /tmp Bin Meng
2022-10-01  3:41   ` Bin Meng
2022-09-27 11:05 ` [PATCH v4 03/54] tcg: " Bin Meng
2022-10-01  3:42   ` Bin Meng
2022-09-27 11:05 ` [PATCH v4 04/54] util/qemu-sockets: Use g_get_tmp_dir() to get the directory for temporary files Bin Meng
2022-10-01  3:44   ` Bin Meng
2022-10-03 10:28     ` Daniel P. Berrangé
2022-09-27 11:05 ` [PATCH v4 05/54] tests/qtest: ahci-test: Avoid using hardcoded /tmp Bin Meng
2022-09-27 11:05 ` [PATCH v4 06/54] tests/qtest: aspeed_smc-test: " Bin Meng
2022-09-27 11:05 ` [PATCH v4 07/54] tests/qtest: boot-serial-test: " Bin Meng
2022-09-27 11:05 ` [PATCH v4 08/54] tests/qtest: cxl-test: " Bin Meng
2022-09-27 11:05 ` [PATCH v4 09/54] tests/qtest: fdc-test: " Bin Meng
2022-09-27 11:05 ` [PATCH v4 10/54] tests/qtest: generic_fuzz: " Bin Meng
2022-09-27 11:05 ` [PATCH v4 11/54] tests/qtest: virtio_blk_fuzz: " Bin Meng
2022-09-27 11:05 ` [PATCH v4 12/54] tests/qtest: hd-geo-test: " Bin Meng
2022-09-27 12:21   ` Thomas Huth
2022-09-27 11:05 ` [PATCH v4 13/54] tests/qtest: ide-test: " Bin Meng
2022-09-27 11:05 ` [PATCH v4 14/54] tests/qtest: migration-test: " Bin Meng
2022-09-27 14:26   ` Marc-André Lureau
2022-09-27 11:05 ` [PATCH v4 15/54] tests/qtest: pflash-cfi02-test: " Bin Meng
2022-09-27 14:27   ` Marc-André Lureau
2022-09-27 11:05 ` [PATCH v4 16/54] tests/qtest: qmp-test: " Bin Meng
2022-09-27 14:27   ` Marc-André Lureau
2022-09-27 11:05 ` [PATCH v4 17/54] tests/qtest: vhost-user-blk-test: " Bin Meng
2022-09-27 11:05 ` [PATCH v4 18/54] tests/qtest: vhost-user-test: " Bin Meng
2022-09-27 14:28   ` Marc-André Lureau
2022-09-27 11:05 ` [PATCH v4 19/54] tests/qtest: virtio-blk-test: " Bin Meng
2022-09-27 11:05 ` [PATCH v4 20/54] tests/qtest: virtio-scsi-test: " Bin Meng
2022-09-27 11:05 ` [PATCH v4 21/54] tests/qtest: libqtest: " Bin Meng
2022-09-27 11:06 ` [PATCH v4 22/54] tests/unit: test-image-locking: " Bin Meng
2022-09-27 11:06 ` [PATCH v4 23/54] tests/unit: test-qga: " Bin Meng
2022-09-27 11:06 ` [PATCH v4 24/54] tests: vhost-user-bridge: " Bin Meng
2022-09-27 11:06 ` [PATCH v4 25/54] block/vvfat: Unify the mkdir() call Bin Meng
2022-10-01  3:46   ` Bin Meng
2022-09-27 11:06 ` [PATCH v4 26/54] fsdev/virtfs-proxy-helper: Use g_mkdir() Bin Meng
2022-10-01  3:48   ` Bin Meng
2022-10-01 12:12     ` Christian Schoenebeck
2022-09-27 11:06 ` [PATCH v4 27/54] hw/usb: dev-mtp: " Bin Meng
2022-10-01  3:49   ` Bin Meng
2022-09-27 11:06 ` [PATCH v4 28/54] tests/qtest: Skip running virtio-net-test cases that require socketpair() for win32 Bin Meng
2022-09-27 11:06 ` [PATCH v4 29/54] tests/qtest: Build test-filter-{mirror, redirector} cases for posix only Bin Meng
2022-09-27 11:06 ` [PATCH v4 30/54] tests/qtest: qmp-test: Skip running test_qmp_oob for win32 Bin Meng
2022-09-27 11:06 ` [PATCH v4 31/54] accel/qtest: Implement a portable qtest accelerator Bin Meng
2022-09-28  9:00   ` Thomas Huth
2022-09-27 11:06 ` [PATCH v4 32/54] tests/qtest: libqtest: Adapt global_qtest declaration for win32 Bin Meng
2022-09-27 11:06 ` [PATCH v4 33/54] tests/qtest: Use send/recv for socket communication Bin Meng
2022-09-27 11:06 ` [PATCH v4 34/54] tests/qtest: libqtest: Exclude the *_fds APIs for win32 Bin Meng
2022-09-27 11:06 ` [PATCH v4 35/54] tests/qtest: libqtest: Install signal handler via signal() Bin Meng
2022-09-28  9:42   ` Thomas Huth
2022-09-28  9:57     ` Bin Meng
2022-09-28 10:03       ` Thomas Huth
2022-09-27 11:06 ` [PATCH v4 36/54] tests/qtest: Support libqtest to build and run on Windows Bin Meng
2022-09-27 11:06 ` [PATCH v4 37/54] tests/qtest: {ahci, ide}-test: Use relative path for temporary files for win32 Bin Meng
2022-09-27 11:06 ` [PATCH v4 38/54] tests/qtest: bios-tables-test: Adapt the case " Bin Meng
2022-09-27 11:06 ` [PATCH v4 39/54] tests/qtest: boot-serial-test: Close the serial file before starting QEMU Bin Meng
2022-09-27 14:29   ` Marc-André Lureau
2022-09-27 11:06 ` [PATCH v4 40/54] tests/qtest: ide-test: Open file in binary mode Bin Meng
2022-09-27 11:06 ` [PATCH v4 41/54] tests/qtest: microbit-test: Fix socket access for win32 Bin Meng
2022-09-27 11:06 ` [PATCH v4 42/54] tests/qtest: migration-test: Disable IO redirection " Bin Meng
2022-09-27 11:06 ` [PATCH v4 43/54] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled Bin Meng
2022-09-27 13:15   ` Marc-André Lureau
2022-09-27 13:21     ` Bin Meng
2022-09-27 14:23       ` Marc-André Lureau
2022-09-27 11:06 ` [PATCH v4 44/54] tests/qtest: virtio-net-failover: Disable migration tests for win32 Bin Meng
2022-09-27 11:06 ` [PATCH v4 45/54] tests/qtest: libqtest: Replace the call to close a socket with closesocket() Bin Meng
2022-09-27 11:06 ` [PATCH v4 46/54] tests/qtest: libqtest: Correct the timeout unit of blocking receive calls for win32 Bin Meng
2022-09-27 11:06 ` [PATCH v4 47/54] io/channel-watch: Drop a superfluous '#ifdef WIN32' Bin Meng
2022-09-27 11:06 ` [PATCH v4 48/54] io/channel-watch: Drop the unnecessary cast Bin Meng
2022-09-27 11:06 ` [PATCH v4 49/54] io/channel-watch: Fix socket watch on Windows Bin Meng
2022-09-27 11:06 ` [PATCH v4 50/54] tests/qtest: migration-test: Skip running some TLS cases for win32 Bin Meng
2022-09-27 14:32   ` Marc-André Lureau
2022-09-27 14:38     ` Bin Meng
2022-09-27 14:47       ` Marc-André Lureau
2022-09-27 11:06 ` [PATCH v4 51/54] .gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes Bin Meng
2022-09-27 11:06 ` [PATCH v4 52/54] .gitlab-ci.d/windows.yml: Display meson test logs Bin Meng
2022-09-27 11:06 ` [PATCH v4 53/54] tests/qtest: Enable qtest build on Windows Bin Meng
2022-09-27 13:34   ` Thomas Huth
2022-09-27 11:06 ` [PATCH v4 54/54] docs/devel: testing: Document writing portable test cases Bin Meng
2022-09-27 13:36   ` Thomas Huth
2022-09-28 10:31 ` [PATCH v4 00/54] tests/qtest: Enable running qtest on Windows Thomas Huth
2022-09-28 15:24   ` Thomas Huth
2022-09-28 15:30     ` Daniel P. Berrangé
2022-10-03  9:25 ` Marc-André Lureau
2022-10-03 10:08   ` Bin Meng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEUhbmXXUcW0jb4VXBHeemjZoHD2fcnzMmfo=rX55BREN2KXHA@mail.gmail.com' \
    --to=bmeng.cn@gmail.com \
    --cc=Coiby.Xu@gmail.com \
    --cc=Qiuhao.Li@outlook.com \
    --cc=alex.bennee@linaro.org \
    --cc=alxndr@bu.edu \
    --cc=andrew@aj.id.au \
    --cc=ani@anisinha.ca \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bin.meng@windriver.com \
    --cc=bleal@redhat.com \
    --cc=bsd@redhat.com \
    --cc=clg@kaod.org \
    --cc=darren.kenny@oracle.com \
    --cc=dgilbert@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=groug@kaod.org \
    --cc=hreitz@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=joel@jms.id.au \
    --cc=jsnow@redhat.com \
    --cc=kkostiuk@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=michael.roth@amd.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wangyanan55@huawei.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.