From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Meng Date: Mon, 26 Sep 2016 14:42:25 +0800 Subject: [U-Boot] [PATCH] x86: baytrail: Add 2nd eMMC controller to the PCI probe list In-Reply-To: References: <20160916123757.17205-1-sr@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, On Mon, Sep 26, 2016 at 2:39 PM, Stefan Roese wrote: > Hi Bin, > > On 26.09.2016 08:33, Bin Meng wrote: >> >> On Fri, Sep 16, 2016 at 8:37 PM, Stefan Roese wrote: >>> >>> With this addition, the eMMC device available on the congatec and DFI >>> BayTrail SoM is detected correctly. >>> >>> Signed-off-by: Stefan Roese >>> Cc: Simon Glass >>> Cc: Bin Meng >>> --- >>> arch/x86/cpu/baytrail/valleyview.c | 1 + >>> include/pci_ids.h | 1 + >>> 2 files changed, 2 insertions(+) >>> >>> diff --git a/arch/x86/cpu/baytrail/valleyview.c >>> b/arch/x86/cpu/baytrail/valleyview.c >>> index b31f24e..9868de0 100644 >>> --- a/arch/x86/cpu/baytrail/valleyview.c >>> +++ b/arch/x86/cpu/baytrail/valleyview.c >>> @@ -14,6 +14,7 @@ >>> static struct pci_device_id mmc_supported[] = { >>> { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDIO }, >>> { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDCARD }, >>> + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2 }, >> >> >> pure nits, should we use VALLEYVIEW_EMMC2? or should we change >> previous VALLEYVIEW_SDIO/SDCARD to BYT_SDIO/SDCARD, for consistency? > > > I've taken the new name from the Linux driver as you might have > already suspected. I would prefer to change the other (old) names > to the Linux ones. I can prepare a v2 of this patch or a follow-up > patch for this. What would you prefer? > Sure, let's match Linux. Regards, Bin