From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48EFAC433F5 for ; Fri, 12 Nov 2021 01:29:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 108AC6124D for ; Fri, 12 Nov 2021 01:29:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 108AC6124D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 67DC683777; Fri, 12 Nov 2021 02:28:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TJtCqDzK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EC52E83A0F; Fri, 12 Nov 2021 02:28:56 +0100 (CET) Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A95C083777 for ; Fri, 12 Nov 2021 02:28:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-yb1-xb34.google.com with SMTP id s186so19561272yba.12 for ; Thu, 11 Nov 2021 17:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X46676bg5p75HPBiV2I/9Le6dhZSD8g9RdSOuQqpYvg=; b=TJtCqDzKY1I12B8fhecr9oviAQDk4rO8SD+FA22FTsPqPSxRlpNXDPg1B8EKuU1EgC VPY2sP4cDQrQPKqhgXuNP4GI/bA3hMBxqLcvt35Qm7KegHFpHwdqJkYAvu5LmJPSWPw2 IxQUm2vxXyOPGq7mA5hsQ2f1WcXS6xarnhdQWflua7HIv4w9hJ+90wI6r5OpuoZ1rnKI U+SvFW0dspg7y7oyyfZll1CCJ90FIRlxqW/bwqc2QMyR3mzLLCBBnCMUKSxFky7UpWbn nube8kCq8dfP1N7mD5mljc56i95djq2Z4mCLl5N3CoOooXruyUGOkv9vb3UMMot37sGY /QeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X46676bg5p75HPBiV2I/9Le6dhZSD8g9RdSOuQqpYvg=; b=ylO3SWCfChtAPeLNMq8dB9eBNcKynnGqCw3Me+5AnaDWiVmr1b3EfADBTFkqBLvONq 6wsgqxHs6TI17HrJYedePwPJ35ei4BfhPxoI6RZqHGBgXFocMrbNSuCaAMkOiyOQrcSr jeq51aSUXqsLLFgsBPkvUFCpBz3FJOqTXGaiVi8U3046c4ExZlGD8bDmS6MRB54ioLx8 VmXgSMRIDlyIpSw4u1sOmI4aoUKT08SVL3y/PHLmGxpUVsv2RbfkLBPJoDOlMwv+KRHV eHEHr7WPeA3s3YVk05JafvW7ppoKP2JNafX9inAOa622Z5WGQQpwxjQ0/+10/4a2AALV dEwg== X-Gm-Message-State: AOAM533HAPWjdYSQmeCBf6dRr4PE5lnGu6ingUZvzswp91kPBlnN0WjH KgWrVReFIiGh6oHANyBRTHuC+htl/SjV3tkhopk= X-Google-Smtp-Source: ABdhPJzb4ZNZ99ZrtTgDExJvr4zkXy86ZuLoiBlvRxu/EjjXkapEMRt2fRUP0HFmP4FKB6CcshjlbGvJI4rdtlovoyA= X-Received: by 2002:a25:2346:: with SMTP id j67mr13224298ybj.467.1636680532224; Thu, 11 Nov 2021 17:28:52 -0800 (PST) MIME-Version: 1.0 References: <20211111125441.3344243-1-michael@walle.cc> In-Reply-To: From: Bin Meng Date: Fri, 12 Nov 2021 09:28:40 +0800 Message-ID: Subject: Re: [PATCH v1 4/5] net: macb: Compatible as per device tree To: Ivan.Griffin@microchip.com Cc: Michael Walle , Padmarao Begari , Anup Patel , Atish Patra , Conor Dooley , Cyril.Jean@microchip.com, Daire McNamara , Heiko Schocher , Lewis Hanly , Padmarao Begari , Rick Chen , U-Boot Mailing List , Valentina.FernandezAlanis@microchip.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Nov 11, 2021 at 9:17 PM wrote: > > > I agree with Bin here. You shouldn't introduce a new compatible just for > > u-boot. If you need one, please to it first in linux and get an ACK there. > > Or at least there should be patches for it pending in linux and it should > > be likely, that they will be accepted. > > > > Please work towards having one binding for u-boot and linux. > > > > -michael > > I think both Michael and Bin are right, but that maybe this has gone circular. > > IIRC, Linux *doesn't need* any extra bindings because its driver already > supports 64-bit DMA. > > Padmarao's original patch added equivalent 64-bit functionality to the > driver in U-Boot, but this was rejected. > I am not sure why it was rejected. Is that because it breaks some other platforms? > Instead I think the suggestion was to add a device-tree binding to choose 32 or > 64-bit DMA... however, there is no reasonably way of upstreaming this into > the Linux device-tree, as Linux doesn't need it... so he is left in a Catch-22. > > A way forward may be to go back to his original approach and get the U-Boot > driver functionality updated so that it works similarly to the Linux driver > (and thus can use the same device-tree stanza)? Let's go back to the original approach and see what happens. Regards, Bin