From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bin Meng <bmeng.cn@gmail.com>
Date: Wed, 2 Oct 2019 21:56:04 +0800
Subject: [U-Boot] [PATCH v2 02/38] binman: Allow selection of logging
	verbosity
In-Reply-To: <20190925141147.191166-3-sjg@chromium.org>
References: <20190925141147.191166-1-sjg@chromium.org>
 <20190925141147.191166-3-sjg@chromium.org>
Message-ID: <CAEUhbmXhftCS0zisHTE_mkq=-B98pQz8TBc8A4a4emJKNP06Wg@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, Sep 25, 2019 at 10:12 PM Simon Glass <sjg@chromium.org> wrote:
>
> Support a new BINMAN_VERBOSE option to the build, to allow passing the
> -v flag to binman.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2: None
>
>  Makefile            | 3 ++-
>  tools/binman/README | 6 ++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index c5caec8267e..fd390e19458 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1214,7 +1214,8 @@ u-boot.ldr:       u-boot
>  quiet_cmd_binman = BINMAN  $@
>  cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \
>                  --toolpath $(objtree)/tools \
> -                build -u -d u-boot.dtb -O . -m \
> +               $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \
> +               build -u -d u-boot.dtb -O . -m \
>                 -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \
>                 $(BINMAN_$(@F))
>
> diff --git a/tools/binman/README b/tools/binman/README
> index b4f6392ab74..8e0f0a8c55b 100644
> --- a/tools/binman/README
> +++ b/tools/binman/README
> @@ -934,6 +934,12 @@ BINMAN_DEBUG=1 to your build:
>     make sandbox_defconfig
>     make BINMAN_DEBUG=1
>
> +To enable verbose logging from binman, base BINMAN_VERBOSE to your build, which
> +adds a -v<level> option to the call to binman:
> +
> +   make sandbox_defconfig

I don't see sandbox_defconfig enables BINMAN. Shouldn't it be
qemu-x86_defconfig?

> +   make BINMAN_VERBOSE=5
> +
>
>  History / Credits
>  -----------------
> --

Other than that,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin